chrome/browser/component_updater/pnacl/pnacl_component_installer.h - Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_component_installer.h

Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pepper_flash_component_installer.cc ('k') | chrome/browser/component_updater/recovery_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/pnacl/pnacl_component_installer.h

diff --git a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h

index 14005f7191e09b24a7dcbf75788b272785b72e63..fb5a6145dc97bcd1e5559a58533bd7e809104583 100644

--- a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h

+++ b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h

@@ -39,15 +39,15 @@ class PnaclComponentInstaller : public ComponentInstaller {

public:

PnaclComponentInstaller();

- virtual ~PnaclComponentInstaller();

+ ~PnaclComponentInstaller() override;

- virtual void OnUpdateError(int error) override;

+ void OnUpdateError(int error) override;

- virtual bool Install(const base::DictionaryValue& manifest,

- const base::FilePath& unpack_path) override;

+ bool Install(const base::DictionaryValue& manifest,

+ const base::FilePath& unpack_path) override;

- virtual bool GetInstalledFile(const std::string& file,

- base::FilePath* installed_file) override;

+ bool GetInstalledFile(const std::string& file,

+ base::FilePath* installed_file) override;

// Register a PNaCl component for the first time.

void RegisterPnaclComponent(ComponentUpdateService* cus);