Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Peter Kasting
CC:
benquan, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, David Black, Dane Wallinga, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, dyu1, estade+watch_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, miu+watch_chromium.org, rouslan+autofillwatch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/063a31d2f60f42f1b27006f26054e471ff26013e Cr-Commit-Position: refs/heads/master@{#299929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -87 lines) Patch
M chrome/browser/ui/android/infobars/confirm_infobar.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/alternate_nav_infobar_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/search_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/settings_api_bubble_helper_views.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 16:04:43 UTC) #2
Peter Kasting
Rubber-stamp LGTM
6 years, 2 months ago (2014-10-16 17:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657333002/1
6 years, 2 months ago (2014-10-16 17:38:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 18:07:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:09:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/063a31d2f60f42f1b27006f26054e471ff26013e
Cr-Commit-Position: refs/heads/master@{#299929}

Powered by Google App Engine
This is Rietveld 408576698