Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h" 10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 DCHECK(!shown_suspicious_extensions_bubble_); 323 DCHECK(!shown_suspicious_extensions_bubble_);
324 324
325 scoped_ptr<SuspiciousExtensionBubbleController> suspicious_extensions( 325 scoped_ptr<SuspiciousExtensionBubbleController> suspicious_extensions(
326 new SuspiciousExtensionBubbleController(profile_)); 326 new SuspiciousExtensionBubbleController(profile_));
327 if (!suspicious_extensions->ShouldShow()) 327 if (!suspicious_extensions->ShouldShow())
328 return false; 328 return false;
329 329
330 shown_suspicious_extensions_bubble_ = true; 330 shown_suspicious_extensions_bubble_ = true;
331 SuspiciousExtensionBubbleController* weak_controller = 331 SuspiciousExtensionBubbleController* weak_controller =
332 suspicious_extensions.get(); 332 suspicious_extensions.get();
333 ExtensionMessageBubbleView* bubble_delegate = new ExtensionMessageBubbleView( 333 ExtensionMessageBubbleView* bubble_delegate =
334 anchor_view, 334 new ExtensionMessageBubbleView(anchor_view,
335 views::BubbleBorder::TOP_RIGHT, 335 views::BubbleBorder::TOP_RIGHT,
336 suspicious_extensions.PassAs<ExtensionMessageBubbleController>()); 336 suspicious_extensions.Pass());
337 337
338 views::BubbleDelegateView::CreateBubble(bubble_delegate); 338 views::BubbleDelegateView::CreateBubble(bubble_delegate);
339 weak_controller->Show(bubble_delegate); 339 weak_controller->Show(bubble_delegate);
340 340
341 return true; 341 return true;
342 } 342 }
343 343
344 bool ExtensionMessageBubbleFactory::MaybeShowStartupOverrideExtensionsBubble( 344 bool ExtensionMessageBubbleFactory::MaybeShowStartupOverrideExtensionsBubble(
345 views::View* anchor_view) { 345 views::View* anchor_view) {
346 #if !defined(OS_WIN) 346 #if !defined(OS_WIN)
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 } 504 }
505 505
506 void ExtensionMessageBubbleFactory::Finish() { 506 void ExtensionMessageBubbleFactory::Finish() {
507 MaybeStopObserving(); 507 MaybeStopObserving();
508 controller_.reset(); 508 controller_.reset();
509 anchor_view_ = NULL; 509 anchor_view_ = NULL;
510 container_ = NULL; 510 container_ = NULL;
511 } 511 }
512 512
513 } // namespace extensions 513 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698