chrome/browser/ui/app_list/extension_app_model_builder.cc - Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder.cc

Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/app_list/search/app_search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/extension_app_model_builder.cc

diff --git a/chrome/browser/ui/app_list/extension_app_model_builder.cc b/chrome/browser/ui/app_list/extension_app_model_builder.cc

index 5e8067481936d51dae247d10cad30a83aaeffcc6..68ed129ddc89951d22afec5c913c782f627ba2b1 100644

--- a/chrome/browser/ui/app_list/extension_app_model_builder.cc

+++ b/chrome/browser/ui/app_list/extension_app_model_builder.cc

@@ -285,10 +285,10 @@ void ExtensionAppModelBuilder::PopulateApps() {

void ExtensionAppModelBuilder::InsertApp(scoped_ptr<ExtensionAppItem> app) {

if (service_) {

- service_->AddItem(app.PassAs<app_list::AppListItem>());

+ service_->AddItem(app.Pass());

return;

}

- model_->AddItem(app.PassAs<app_list::AppListItem>());

+ model_->AddItem(app.Pass());

}

ExtensionAppItem* ExtensionAppModelBuilder::GetExtensionAppItem(