chrome/browser/ui/views/extensions/extension_message_bubble_view.cc - Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_media_picker_views_unittest.cc ('k') | chrome/browser/ui/views/extensions/extension_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

index b33beb60edb0bf900cfc313a63b8c207b7e3618d..0264189e2fbf6b05ad2935c595807813f1ac3b31 100644

--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

@@ -330,10 +330,10 @@ bool ExtensionMessageBubbleFactory::MaybeShowSuspiciousExtensionsBubble(

shown_suspicious_extensions_bubble_ = true;

SuspiciousExtensionBubbleController* weak_controller =

suspicious_extensions.get();

- ExtensionMessageBubbleView* bubble_delegate = new ExtensionMessageBubbleView(

- anchor_view,

- views::BubbleBorder::TOP_RIGHT,

- suspicious_extensions.PassAs<ExtensionMessageBubbleController>());

+ ExtensionMessageBubbleView* bubble_delegate =

+ new ExtensionMessageBubbleView(anchor_view,

+ views::BubbleBorder::TOP_RIGHT,

+ suspicious_extensions.Pass());

views::BubbleDelegateView::CreateBubble(bubble_delegate);

weak_controller->Show(bubble_delegate);