Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4262)

Unified Diff: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/profiles/new_avatar_button.cc ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/settings_api_bubble_helper_views.cc
diff --git a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
index 32a484e97c26292e3a3e8724468082a76f201237..6bc803c69eb692dfa3f8c96e12d80206d697199c 100644
--- a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
+++ b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc
@@ -34,12 +34,8 @@ void ShowSettingsApiBubble(SettingsApiOverrideType type,
return;
SettingsApiBubbleController* controller = settings_api_bubble.get();
- ExtensionMessageBubbleView* bubble_delegate =
- new ExtensionMessageBubbleView(
- anchor_view,
- arrow,
- settings_api_bubble.PassAs<
- ExtensionMessageBubbleController>());
+ ExtensionMessageBubbleView* bubble_delegate = new ExtensionMessageBubbleView(
+ anchor_view, arrow, settings_api_bubble.Pass());
views::BubbleDelegateView::CreateBubble(bubble_delegate);
controller->Show(bubble_delegate);
}
@@ -119,12 +115,10 @@ void MaybeShowExtensionControlledNewTabPage(
return;
NtpOverriddenBubbleController* controller = ntp_overridden_bubble.get();
- ExtensionMessageBubbleView* bubble_delegate =
- new ExtensionMessageBubbleView(
- BrowserView::GetBrowserViewForBrowser(browser)->toolbar()->app_menu(),
- views::BubbleBorder::TOP_RIGHT,
- ntp_overridden_bubble.PassAs<
- ExtensionMessageBubbleController>());
+ ExtensionMessageBubbleView* bubble_delegate = new ExtensionMessageBubbleView(
+ BrowserView::GetBrowserViewForBrowser(browser)->toolbar()->app_menu(),
+ views::BubbleBorder::TOP_RIGHT,
+ ntp_overridden_bubble.Pass());
views::BubbleDelegateView::CreateBubble(bubble_delegate);
controller->Show(bubble_delegate);
}
« no previous file with comments | « chrome/browser/ui/views/profiles/new_avatar_button.cc ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698