chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm - Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

Issue 657333002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm ('k') | chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

diff --git a/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm b/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

index f98dfeebcb5333b7c60e9cb607bddf0735c7295f..209e5d51c3d74628e9d927d198069d5a042e0ed1 100644

--- a/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

+++ b/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

@@ -30,8 +30,7 @@ using InfoBarUtilities::AddMenuItem;

scoped_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(

scoped_ptr<translate::TranslateInfoBarDelegate> delegate) const {

- scoped_ptr<InfoBarCocoa> infobar(

- new InfoBarCocoa(delegate.PassAs<infobars::InfoBarDelegate>()));

+ scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(delegate.Pass()));

base::scoped_nsobject<TranslateInfoBarControllerBase> infobar_controller;

switch (infobar->delegate()->AsTranslateInfoBarDelegate()->translate_step()) {

case translate::TRANSLATE_STEP_BEFORE_TRANSLATE:

@@ -51,7 +50,7 @@ scoped_ptr<infobars::InfoBar> ChromeTranslateClient::CreateInfoBar(

NOTREACHED();

}

infobar->set_controller(infobar_controller);

- return infobar.PassAs<infobars::InfoBar>();

+ return infobar.Pass();

}

@implementation TranslateInfoBarControllerBase (FrameChangeObserver)