Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656503002: Move willUseInputColor check to computeInvariantOutput (Closed)

Created:
6 years, 2 months ago by egdaniel
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@addMultFlag
Project:
skia
Visibility:
Public.

Description

Move willUseInputColor check to computeInvariantOutput BUG=skia: Committed: https://skia.googlesource.com/skia/+/9e4d6d180fcfbbe2ea242196cc0affd45b7ed7ae

Patch Set 1 #

Patch Set 2 : Update InvariantOutput validate #

Total comments: 2

Patch Set 3 : Make WillReadInput be a param #

Patch Set 4 : Rebase for real #

Patch Set 5 : Rebase maybe? #

Patch Set 6 : Test #

Patch Set 7 : #

Total comments: 2

Patch Set 8 : Change setToTransBlack to mulByKnownAlpha #

Patch Set 9 : Rebase #

Patch Set 10 : Rebase2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -47 lines) Patch
M include/gpu/GrPaint.h View 6 2 chunks +0 lines, -6 lines 0 comments Download
M include/gpu/GrProcessor.h View 1 2 3 4 5 6 7 8 9 5 chunks +36 lines, -9 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +12 lines, -12 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 5 6 7 8 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 2 3 4 5 6 7 8 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
egdaniel
6 years, 2 months ago (2014-10-13 19:35:25 UTC) #2
bsalomon
https://codereview.chromium.org/656503002/diff/90001/include/gpu/GrProcessor.h File include/gpu/GrProcessor.h (right): https://codereview.chromium.org/656503002/diff/90001/include/gpu/GrProcessor.h#newcode100 include/gpu/GrProcessor.h:100: void setWillNotUseInputColor() { Instead of a new setter can ...
6 years, 2 months ago (2014-10-13 20:54:42 UTC) #3
egdaniel
https://codereview.chromium.org/656503002/diff/90001/include/gpu/GrProcessor.h File include/gpu/GrProcessor.h (right): https://codereview.chromium.org/656503002/diff/90001/include/gpu/GrProcessor.h#newcode100 include/gpu/GrProcessor.h:100: void setWillNotUseInputColor() { On 2014/10/13 20:54:42, bsalomon wrote: > ...
6 years, 2 months ago (2014-10-14 17:49:57 UTC) #4
egdaniel
ping
6 years, 2 months ago (2014-10-15 13:26:34 UTC) #5
bsalomon
https://codereview.chromium.org/656503002/diff/240001/include/gpu/GrProcessor.h File include/gpu/GrProcessor.h (right): https://codereview.chromium.org/656503002/diff/240001/include/gpu/GrProcessor.h#newcode85 include/gpu/GrProcessor.h:85: void setToTransparentBlack(ReadInput readsInput) { Does this one need it? ...
6 years, 2 months ago (2014-10-15 14:52:42 UTC) #6
egdaniel
https://codereview.chromium.org/656503002/diff/240001/include/gpu/GrProcessor.h File include/gpu/GrProcessor.h (right): https://codereview.chromium.org/656503002/diff/240001/include/gpu/GrProcessor.h#newcode85 include/gpu/GrProcessor.h:85: void setToTransparentBlack(ReadInput readsInput) { On 2014/10/15 14:52:42, bsalomon wrote: ...
6 years, 2 months ago (2014-10-15 18:37:48 UTC) #7
bsalomon
lgtm
6 years, 2 months ago (2014-10-15 18:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656503002/300001
6 years, 2 months ago (2014-10-15 19:23:07 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 20:49:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #10 (id:300001) as 9e4d6d180fcfbbe2ea242196cc0affd45b7ed7ae

Powered by Google App Engine
This is Rietveld 408576698