C++11 declares a type safe null pointer

C++11 declares a type safe null pointer

This change converts from NULL to
nullptr

BUG=

[MRV, 2014-10-10 10:03:45]

mohan.reddy@samsung.com changed reviewers:
+ nasko@chromium.org

[MRV, 2014-10-10 10:03:46]

Dear Mr. nasko
We are planning to incorporate c++11 constructs in chromium.

PTAL

[Avi (use Gerrit), 2014-10-10 16:55:34]

Your change description makes no sense. "[C++11 Allowed Features] Declares a
type-safe null pointer converting from NULL to  nullptr". This change does not
declare any pointers. This description seems to mash together two sentences:
"C++11 declares a type safe null pointer" and "This change converts from NULL to
nullptr". Please rewrite it to be grammatical English.

Also, if we’re doing a bulk conversion from NULL to nullptr, we should have a
master BUG tying this all together.

[MRV, 2014-10-10 18:04:19]

On 2014/10/10 16:55:34, Avi wrote:
> Your change description makes no sense. "[C++11 Allowed Features] Declares a
> type-safe null pointer converting from NULL to  nullptr". This change does not
> declare any pointers. This description seems to mash together two sentences:
> "C++11 declares a type safe null pointer" and "This change converts from NULL
to
> nullptr". Please rewrite it to be grammatical English.
> 
> Also, if we’re doing a bulk conversion from NULL to nullptr, we should have a
> master BUG tying this all together.

Thanks mr. Avi. For your feedback. Your point makes more sense to me.
I have updated headings accordingly.
I have checked c++11 reference and started updating same.
Could you please create bug for the same else do you want me to create.
Thanks in advance.

[Avi (use Gerrit), 2014-10-10 18:23:22]

On 2014/10/10 18:04:19, MRV wrote:
> On 2014/10/10 16:55:34, Avi wrote:
> > Your change description makes no sense. "[C++11 Allowed Features] Declares a
> > type-safe null pointer converting from NULL to  nullptr". This change does
not
> > declare any pointers. This description seems to mash together two sentences:
> > "C++11 declares a type safe null pointer" and "This change converts from
NULL
> to
> > nullptr". Please rewrite it to be grammatical English.
> > 
> > Also, if we’re doing a bulk conversion from NULL to nullptr, we should have
a
> > master BUG tying this all together.
> 
> Thanks mr. Avi. For your feedback. Your point makes more sense to me.
> I have updated headings accordingly.
> I have checked c++11 reference and started updating same.
> Could you please create bug for the same else do you want me to create.
> Thanks in advance.

Please create a bug, and have your colleagues that are helping with this task
also link to that bug.

[MRV, 2014-10-10 18:42:03]

On 2014/10/10 18:23:22, Avi wrote:
> On 2014/10/10 18:04:19, MRV wrote:
> > On 2014/10/10 16:55:34, Avi wrote:
> > > Your change description makes no sense. "[C++11 Allowed Features] Declares
a
> > > type-safe null pointer converting from NULL to  nullptr". This change does
> not
> > > declare any pointers. This description seems to mash together two
sentences:
> > > "C++11 declares a type safe null pointer" and "This change converts from
> NULL
> > to
> > > nullptr". Please rewrite it to be grammatical English.
> > > 
> > > Also, if we’re doing a bulk conversion from NULL to nullptr, we should
have
> a
> > > master BUG tying this all together.
> > 
> > Thanks mr. Avi. For your feedback. Your point makes more sense to me.
> > I have updated headings accordingly.
> > I have checked c++11 reference and started updating same.
> > Could you please create bug for the same else do you want me to create.
> > Thanks in advance.
> 
> Please create a bug, and have your colleagues that are helping with this task
> also link to that bug.

Thanks mr. Avi, I'll follow the same.

[Avi (use Gerrit), 2014-10-10 21:17:17]

Peter wrote up a guideline as to doing these kinds of changes:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU

[MRV, 2014-10-13 12:29:40]

On 2014/10/10 21:17:17, Avi wrote:
> Peter wrote up a guideline as to doing these kinds of changes:
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU

Thanks Mr. Avi, for providing the feedback and the link about the same.
I just want following clarification from you before going ahead for rasing the
bug:
Just now I checked with gcc4.6 compiler, nullptr undefined error is been seen,
where with clang and gcc4.8 compilation is went well without any issue.
I just want to know whether we need to support backward compatability to support
gcc4.6 any more, as ubuntu default version still uses gcc4.6 as default, if
we'll not upgrade the same.

[Avi (use Gerrit), 2014-10-13 15:26:15]

On 2014/10/13 12:29:40, MRV wrote:
> On 2014/10/10 21:17:17, Avi wrote:
> > Peter wrote up a guideline as to doing these kinds of changes:
> >
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU
> 
> Thanks Mr. Avi, for providing the feedback and the link about the same.
> I just want following clarification from you before going ahead for rasing the
> bug:
> Just now I checked with gcc4.6 compiler, nullptr undefined error is been seen,
> where with clang and gcc4.8 compilation is went well without any issue.
> I just want to know whether we need to support backward compatability to
support
> gcc4.6 any more, as ubuntu default version still uses gcc4.6 as default, if
> we'll not upgrade the same.

Several weeks ago, based on the toolchains Chromium supports, the decision was
made to allow C++11. Then, without prompting (that I'm aware of), you and your
colleagues launched a huge push to switch from NULL to nullptr. And that was
pretty nice of you guys, to help us with the undertaking of modernizing the
codebase.

So it's surprising to me that _now_, in this review, that you're questioning
whether it's a good idea or it should be done. It's a legitimate question, but
the review in which the modernization is being made is hardly the place. This
question belongs on chromium-dev.

[MRV, 2014-10-13 17:57:08]

On 2014/10/13 15:26:15, Avi wrote:
> On 2014/10/13 12:29:40, MRV wrote:
> > On 2014/10/10 21:17:17, Avi wrote:
> > > Peter wrote up a guideline as to doing these kinds of changes:
> > >
> >
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU
> > 
> > Thanks Mr. Avi, for providing the feedback and the link about the same.
> > I just want following clarification from you before going ahead for rasing
the
> > bug:
> > Just now I checked with gcc4.6 compiler, nullptr undefined error is been
seen,
> > where with clang and gcc4.8 compilation is went well without any issue.
> > I just want to know whether we need to support backward compatability to
> support
> > gcc4.6 any more, as ubuntu default version still uses gcc4.6 as default, if
> > we'll not upgrade the same.
> 
> Several weeks ago, based on the toolchains Chromium supports, the decision was
> made to allow C++11. Then, without prompting (that I'm aware of), you and your
> colleagues launched a huge push to switch from NULL to nullptr. And that was
> pretty nice of you guys, to help us with the undertaking of modernizing the
> codebase.
> 
> So it's surprising to me that _now_, in this review, that you're questioning
> whether it's a good idea or it should be done. It's a legitimate question, but
> the review in which the modernization is being made is hardly the place. This
> question belongs on chromium-dev.

Thanks Mr. Avi for appreciating for our efforts for modernizing the chromium
code.

I am sorry for raising the question now, I just want to clarify as there were
many places where this changes are been seen.
Rather than getting some mixed response later, I just want clarify the same.

I have just posted my query in the discussion thread:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU.

I am apologizing for asking the query at later stage.
Once we get postive reply we'll start contributing for the same.

Once Again thanks for reviewing our patches and sparing your time.

[Avi (use Gerrit), 2014-10-24 21:08:53]

avi@chromium.org changed reviewers:
+ avi@chromium.org