content/common/gpu/media/gpu_video_decode_accelerator.cc - Issue 649533003: C++11 declares a type safe null pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.cc

Issue 649533003: C++11 declares a type safe null pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Presubmit errors Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/gpu_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.cc b/content/common/gpu/media/gpu_video_decode_accelerator.cc

index a830c2ece618c11e30b2921074d6186a8c401786..868cddc1fb33ddf6ef417863572996a6cf003f5e 100644

--- a/content/common/gpu/media/gpu_video_decode_accelerator.cc

+++ b/content/common/gpu/media/gpu_video_decode_accelerator.cc

@@ -76,9 +76,9 @@ class GpuVideoDecodeAccelerator::MessageFilter : public IPC::MessageFilter {

MessageFilter(GpuVideoDecodeAccelerator* owner, int32 host_route_id)

: owner_(owner), host_route_id_(host_route_id) {}

- virtual void OnChannelError() override { sender_ = NULL; }

+ virtual void OnChannelError() override { sender_ = nullptr; }

- virtual void OnChannelClosing() override { sender_ = NULL; }

+ virtual void OnChannelClosing() override { sender_ = nullptr; }

virtual void OnFilterAdded(IPC::Sender* sender) override {

sender_ = sender;