content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h - Issue 649533003: C++11 declares a type safe null pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 649533003: C++11 declares a type safe null pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Presubmit errors Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_video_encode_accelerator_host.cc ('k') | content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

index 9b4c7b6157b0ce1bc993432f18dc15c3f335f22e..de29d5afde39e38e35bbd0c640b21e050f2b452f 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

@@ -68,7 +68,7 @@ class WebGraphicsContext3DCommandBufferImpl

// function.

lock_.AssertAcquired();

if (contexts_.empty())

- return NULL;

+ return nullptr;

return contexts_.front();

}

@@ -127,8 +127,8 @@ class WebGraphicsContext3DCommandBufferImpl

// problem communicating with the GPU process.

bool IsCommandBufferContextLost();

- // Create & initialize a WebGraphicsContext3DCommandBufferImpl. Return NULL

- // on any failure.

+ // Create & initialize a WebGraphicsContext3DCommandBufferImpl.

+ // Return nullptr on any failure.

static CONTENT_EXPORT WebGraphicsContext3DCommandBufferImpl*

CreateOffscreenContext(

GpuChannelHost* host,