Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Side by Side Diff: content/common/shareable_file_reference_unittest.cc

Issue 649533003: C++11 declares a type safe null pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Presubmit errors Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/set_process_title_linux.cc ('k') | content/common/url_schemes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/common/blob/shareable_file_reference.h" 5 #include "storage/common/blob/shareable_file_reference.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/message_loop/message_loop_proxy.h" 9 #include "base/message_loop/message_loop_proxy.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 26 matching lines...) Expand all
37 37
38 // Get a second reference to that file. 38 // Get a second reference to that file.
39 scoped_refptr<ShareableFileReference> reference2; 39 scoped_refptr<ShareableFileReference> reference2;
40 reference2 = ShareableFileReference::Get(file); 40 reference2 = ShareableFileReference::Get(file);
41 EXPECT_EQ(reference1.get(), reference2.get()); 41 EXPECT_EQ(reference1.get(), reference2.get());
42 reference2 = ShareableFileReference::GetOrCreate( 42 reference2 = ShareableFileReference::GetOrCreate(
43 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get()); 43 file, ShareableFileReference::DELETE_ON_FINAL_RELEASE, loop_proxy.get());
44 EXPECT_EQ(reference1.get(), reference2.get()); 44 EXPECT_EQ(reference1.get(), reference2.get());
45 45
46 // Drop the first reference, the file and reference should still be there. 46 // Drop the first reference, the file and reference should still be there.
47 reference1 = NULL; 47 reference1 = nullptr;
48 EXPECT_TRUE(ShareableFileReference::Get(file).get()); 48 EXPECT_TRUE(ShareableFileReference::Get(file).get());
49 base::RunLoop().RunUntilIdle(); 49 base::RunLoop().RunUntilIdle();
50 EXPECT_TRUE(base::PathExists(file)); 50 EXPECT_TRUE(base::PathExists(file));
51 51
52 // Drop the second reference, the file and reference should get deleted. 52 // Drop the second reference, the file and reference should get deleted.
53 reference2 = NULL; 53 reference2 = nullptr;
54 EXPECT_FALSE(ShareableFileReference::Get(file).get()); 54 EXPECT_FALSE(ShareableFileReference::Get(file).get());
55 base::RunLoop().RunUntilIdle(); 55 base::RunLoop().RunUntilIdle();
56 EXPECT_FALSE(base::PathExists(file)); 56 EXPECT_FALSE(base::PathExists(file));
57 57
58 // TODO(michaeln): add a test for files that aren't deletable behavior. 58 // TODO(michaeln): add a test for files that aren't deletable behavior.
59 } 59 }
60 60
61 } // namespace content 61 } // namespace content
OLDNEW
« no previous file with comments | « content/common/set_process_title_linux.cc ('k') | content/common/url_schemes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698