content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc - Issue 649533003: C++11 declares a type safe null pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc

Issue 649533003: C++11 declares a type safe null pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Presubmit errors Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc

index b4ee12872460a79e1487500898dd43bd6ffedae4..900ed2cbfdb775f22ad426342e82fcd6315b8393 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc

@@ -118,7 +118,7 @@ bool GpuMemoryBufferImplSharedMemory::IsConfigurationSupported(

void* GpuMemoryBufferImplSharedMemory::Map() {

DCHECK(!mapped_);

if (!shared_memory_->Map(size_.GetArea() * BytesPerPixel(internalformat_)))

- return NULL;

+ return nullptr;

mapped_ = true;

return shared_memory_->memory();

}