Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 647183002: Revert of Opt state takes a GP instead of a GeometryStage (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
danakj, bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@builder_cleanup
Project:
skia
Visibility:
Public.

Description

Revert of Opt state takes a GP instead of a GeometryStage (patchset #18 id:1500001 of https://codereview.chromium.org/637003003/) Reason for revert: Revert because this may be causing a break in a chrome gpu test Original issue's description: > Opt state takes a GP instead of a GeometryStage > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/71856d520461ae025a0332aa0ce9735a096d9baf TBR=bsalomon@google.com,egdaniel@google.com,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/89c7a2ec3e9f7e1b9705214f450bb12288799da9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -427 lines) Patch
M include/gpu/GrProcessor.h View 6 chunks +19 lines, -18 lines 0 comments Download
M include/gpu/GrProcessorStage.h View 4 chunks +35 lines, -9 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 13 chunks +33 lines, -9 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOptDrawState.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 7 chunks +39 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 11 chunks +72 lines, -64 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 2 chunks +17 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 7 chunks +112 lines, -45 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 4 chunks +33 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 3 chunks +15 lines, -13 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 10 chunks +70 lines, -67 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 8 chunks +134 lines, -131 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshua.litt
Created Revert of Opt state takes a GP instead of a GeometryStage
6 years, 2 months ago (2014-10-10 21:10:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647183002/1
6 years, 2 months ago (2014-10-10 21:11:31 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:12:27 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 89c7a2ec3e9f7e1b9705214f450bb12288799da9

Powered by Google App Engine
This is Rietveld 408576698