Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update virtual/final usage in tools/gn/. Also some #include fixes (from OVERRIDE -> override conversion). BUG=417463 TBR=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/50df3edc46d054d4b7a6cec4098cd1538d66d511

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -127 lines) Patch
M tools/gn/action_target_generator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/binary_target_generator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/builder_unittest.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
M tools/gn/config.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/copy_target_generator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/group_target_generator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/loader.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M tools/gn/ninja_action_target_writer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/ninja_copy_target_writer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/ninja_group_target_writer.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/ninja_target_writer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/parse_tree.h View 1 12 chunks +66 lines, -67 lines 0 comments Download
M tools/gn/scope_per_file_provider.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/setup.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M tools/gn/target.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M tools/gn/toolchain.h View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-21 21:45:54 UTC) #1
Peter Kasting
This seems to overlap with https://codereview.chromium.org/667143003/ .
6 years, 2 months ago (2014-10-21 22:48:09 UTC) #2
viettrungluu
Stealing the LGTM from dcheng's change and landing this TBR (for the extra OVERRIDE -> ...
6 years, 2 months ago (2014-10-22 02:28:30 UTC) #3
viettrungluu
On 2014/10/22 02:28:30, viettrungluu wrote: > Stealing the LGTM from dcheng's change and landing this ...
6 years, 2 months ago (2014-10-22 04:24:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643063004/20001
6 years, 2 months ago (2014-10-22 04:25:41 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/50df3edc46d054d4b7a6cec4098cd1538d66d511 Cr-Commit-Position: refs/heads/master@{#300635}
6 years, 2 months ago (2014-10-22 05:05:53 UTC) #7
viettrungluu
6 years, 2 months ago (2014-10-22 05:08:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
50df3edc46d054d4b7a6cec4098cd1538d66d511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698