tools/gn/binary_target_generator.h - Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/binary_target_generator.h

Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/binary_target_generator.h

diff --git a/tools/gn/binary_target_generator.h b/tools/gn/binary_target_generator.h

index efaaf03a99eb7bff54ebb7c52b860a09572a0884..0b8d521a8ffef2e864b6abb07600bb8554c4edb0 100644

--- a/tools/gn/binary_target_generator.h

+++ b/tools/gn/binary_target_generator.h

@@ -5,7 +5,7 @@

#ifndef TOOLS_GN_BINARY_TARGET_GENERATOR_H_

#define TOOLS_GN_BINARY_TARGET_GENERATOR_H_

-#include "base/compiler_specific.h"

+#include "base/macros.h"

#include "tools/gn/target_generator.h"

// Populates a Target with the values from a binary rule (executable, shared

@@ -20,7 +20,7 @@ class BinaryTargetGenerator : public TargetGenerator {

virtual ~BinaryTargetGenerator();

protected:

- virtual void DoRun() override;

+ void DoRun() override;

private:

bool FillCheckIncludes();

« no previous file with comments | « tools/gn/action_target_generator.h ('k') | tools/gn/builder_unittest.cc » ('j') | no next file with comments »