tools/gn/ninja_action_target_writer.h - Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_action_target_writer.h

Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_action_target_writer.h

diff --git a/tools/gn/ninja_action_target_writer.h b/tools/gn/ninja_action_target_writer.h

index a033e851fee8fce594367628c2c3b391eac69a8a..71c123976220782cadad5b5bdedab0a5f34474d8 100644

--- a/tools/gn/ninja_action_target_writer.h

+++ b/tools/gn/ninja_action_target_writer.h

@@ -7,8 +7,8 @@

#include <vector>

-#include "base/compiler_specific.h"

#include "base/gtest_prod_util.h"

+#include "base/macros.h"

#include "tools/gn/ninja_target_writer.h"

class OutputFile;

@@ -17,9 +17,9 @@ class OutputFile;

class NinjaActionTargetWriter : public NinjaTargetWriter {

public:

NinjaActionTargetWriter(const Target* target, std::ostream& out);

- virtual ~NinjaActionTargetWriter();

+ ~NinjaActionTargetWriter() override;

- virtual void Run() override;

+ void Run() override;

private:

FRIEND_TEST_ALL_PREFIXES(NinjaActionTargetWriter,

« no previous file with comments | « tools/gn/loader.h ('k') | tools/gn/ninja_binary_target_writer.h » ('j') | no next file with comments »