tools/gn/ninja_copy_target_writer.h - Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_copy_target_writer.h

Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_copy_target_writer.h

diff --git a/tools/gn/ninja_copy_target_writer.h b/tools/gn/ninja_copy_target_writer.h

index 01766d8e642cf6806cae1b9539dd207a36265881..9e1746ee9cc09820ebc16cf913bc96273df4c751 100644

--- a/tools/gn/ninja_copy_target_writer.h

+++ b/tools/gn/ninja_copy_target_writer.h

@@ -5,7 +5,7 @@

#ifndef TOOLS_GN_NINJA_COPY_TARGET_WRITER_H_

#define TOOLS_GN_NINJA_COPY_TARGET_WRITER_H_

-#include "base/compiler_specific.h"

+#include "base/macros.h"

#include "tools/gn/ninja_target_writer.h"

class Tool;

@@ -14,9 +14,9 @@ class Tool;

class NinjaCopyTargetWriter : public NinjaTargetWriter {

public:

NinjaCopyTargetWriter(const Target* target, std::ostream& out);

- virtual ~NinjaCopyTargetWriter();

+ ~NinjaCopyTargetWriter() override;

- virtual void Run() override;

+ void Run() override;

private:

// Writes the rules top copy the file(s), putting the computed output file

« no previous file with comments | « tools/gn/ninja_binary_target_writer.h ('k') | tools/gn/ninja_group_target_writer.h » ('j') | no next file with comments »