Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: tools/gn/action_target_generator.h

Issue 643063004: Convert OVERRIDE -> override and update virtual/final usage in tools/gn/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/binary_target_generator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_ACTION_TARGET_GENERATOR_H_ 5 #ifndef TOOLS_GN_ACTION_TARGET_GENERATOR_H_
6 #define TOOLS_GN_ACTION_TARGET_GENERATOR_H_ 6 #define TOOLS_GN_ACTION_TARGET_GENERATOR_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/macros.h"
9 #include "tools/gn/target_generator.h" 9 #include "tools/gn/target_generator.h"
10 10
11 // Populates a Target with the values from an action[_foreach] rule. 11 // Populates a Target with the values from an action[_foreach] rule.
12 class ActionTargetGenerator : public TargetGenerator { 12 class ActionTargetGenerator : public TargetGenerator {
13 public: 13 public:
14 ActionTargetGenerator(Target* target, 14 ActionTargetGenerator(Target* target,
15 Scope* scope, 15 Scope* scope,
16 const FunctionCallNode* function_call, 16 const FunctionCallNode* function_call,
17 Target::OutputType type, 17 Target::OutputType type,
18 Err* err); 18 Err* err);
19 virtual ~ActionTargetGenerator(); 19 virtual ~ActionTargetGenerator();
20 20
21 protected: 21 protected:
22 virtual void DoRun() override; 22 void DoRun() override;
23 23
24 private: 24 private:
25 bool FillScript(); 25 bool FillScript();
26 bool FillScriptArgs(); 26 bool FillScriptArgs();
27 bool FillDepfile(); 27 bool FillDepfile();
28 28
29 // Checks for errors in the outputs variable. 29 // Checks for errors in the outputs variable.
30 bool CheckOutputs(); 30 bool CheckOutputs();
31 31
32 Target::OutputType output_type_; 32 Target::OutputType output_type_;
33 33
34 DISALLOW_COPY_AND_ASSIGN(ActionTargetGenerator); 34 DISALLOW_COPY_AND_ASSIGN(ActionTargetGenerator);
35 }; 35 };
36 36
37 #endif // TOOLS_GN_ACTION_TARGET_GENERATOR_H_ 37 #endif // TOOLS_GN_ACTION_TARGET_GENERATOR_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/binary_target_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698