C++11 override style change for athena

C++11 override style change for athena

Add missing virtual dtor to a few classes.

BUG=417463
R=mukai@chromium.org, sadrul@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/c01e405cdb1bbc1e6d50a0df95b170d29c87f652

[oshima, 2014-10-23 19:07:29]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org, sadrul@chromium.org

[oshima, 2014-10-23 19:07:31]

https://codereview.chromium.org/641683003/diff/1/athena/content/content_proxy.cc
File athena/content/content_proxy.cc (left):

https://codereview.chromium.org/641683003/diff/1/athena/content/content_proxy...
athena/content/content_proxy.cc:45: virtual ~ProxyImageData() {
This turns out to be unnecessary. having virtual is harmless though. let me know
if you think we should keep it.

[dcheng, 2014-10-23 19:11:40]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2014-10-23 19:11:42]

Out of curiosity, how are you generating these patches? Or is this manual?

https://codereview.chromium.org/641683003/diff/1/athena/wm/title_drag_control...
File athena/wm/title_drag_controller.h (right):

https://codereview.chromium.org/641683003/diff/1/athena/wm/title_drag_control...
athena/wm/title_drag_controller.h:44: ~TitleDragController() override;
Formatting seems to be off.

[dcheng, 2014-10-23 19:12:50]

Also, there's a tracking bug for this:
https://crbug.com/417463

[oshima, 2014-10-23 19:20:19]

On 2014/10/23 19:11:42, dcheng wrote:
> Out of curiosity, how are you generating these patches? Or is this manual?

It's a mix.

1) blindly converted using simple script.
   a) virtual ~ -> ~ override
   b) virtual override -> override
2) revert a) where compiler complains because it doesn't override anything.
3) search for virtual manually and see if I missed anything. (mostly virtual and
override are on the different lines)

> 
>
https://codereview.chromium.org/641683003/diff/1/athena/wm/title_drag_control...
> File athena/wm/title_drag_controller.h (right):
> 
>
https://codereview.chromium.org/641683003/diff/1/athena/wm/title_drag_control...
> athena/wm/title_drag_controller.h:44: ~TitleDragController() override;
> Formatting seems to be off.
Oops, forgot to run 'git cl format'. Done, and thanks.
and I updated the BUG=. Thanks again.

[Jun Mukai, 2014-10-23 21:12:22]

lgtm

[oshima, 2014-10-24 11:04:15]

sadrul, I need your approval for ui/keyboard

[sadrul, 2014-10-24 14:43:51]

LGTM

[oshima, 2014-10-24 14:44:28]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-24 14:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641683003/20001

[commit-bot: I haz the power, 2014-10-24 14:52:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 14:52:32]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2014-10-24 15:27:06]

Patchset #3 (id:40001) has been deleted

[oshima, 2014-10-24 17:11:56]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-24 17:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641683003/60001

[commit-bot: I haz the power, 2014-10-24 18:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 18:03:50]

Failed to apply patch for athena/extensions/shell/extensions_delegate_impl.cc:
While running git apply --index -3 -p1;
  error: patch failed: athena/extensions/shell/extensions_delegate_impl.cc:22
  Falling back to three-way merge...
  Applied patch to 'athena/extensions/shell/extensions_delegate_impl.cc' with
conflicts.
  U athena/extensions/shell/extensions_delegate_impl.cc

Patch:       athena/extensions/shell/extensions_delegate_impl.cc
Index: athena/extensions/shell/extensions_delegate_impl.cc
diff --git a/athena/extensions/shell/extensions_delegate_impl.cc
b/athena/extensions/shell/extensions_delegate_impl.cc
index
4b468ef98a1e2999fdfb4827e679a49e75ad483b..ea5fc1f4a7304d774aeb935b99ff0e8aba8d2aba
100644
--- a/athena/extensions/shell/extensions_delegate_impl.cc
+++ b/athena/extensions/shell/extensions_delegate_impl.cc
@@ -22,29 +22,29 @@ class ShellExtensionsDelegate : public ExtensionsDelegate {
     extensions::AppWindowClient::Set(&app_window_client_);
   }
 
-  virtual ~ShellExtensionsDelegate() {
+  ~ShellExtensionsDelegate() override {
     extensions::AppWindowClient::Set(nullptr);
   }
 
  private:
   // ExtensionsDelegate:
-  virtual content::BrowserContext* GetBrowserContext() const override {
+  content::BrowserContext* GetBrowserContext() const override {
     return context_;
   }
-  virtual const extensions::ExtensionSet& GetInstalledExtensions() override {
+  const extensions::ExtensionSet& GetInstalledExtensions() override {
     shell_extensions_.Clear();
     if (extension_system_->extension().get())
       shell_extensions_.Insert(extension_system_->extension());
     return shell_extensions_;
   }
-  virtual bool LaunchApp(const std::string& app_id) override {
+  bool LaunchApp(const std::string& app_id) override {
     extension_system_->LaunchApp();
     return true;
   }
 
-  virtual bool UnloadApp(const std::string& app_id) override { return false; }
+  bool UnloadApp(const std::string& app_id) override { return false; }
 
-  virtual scoped_ptr<extensions::ExtensionInstallUI> CreateExtensionInstallUI()
+  scoped_ptr<extensions::ExtensionInstallUI> CreateExtensionInstallUI()
       override {
     return scoped_ptr<extensions::ExtensionInstallUI>();
   }

[commit-bot: I haz the power, 2014-10-24 18:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 19:27:46]

Patchset 4 (id:??) landed as
https://crrev.com/c01e405cdb1bbc1e6d50a0df95b170d29c87f652
Cr-Commit-Position: refs/heads/master@{#301170}

[oshima, 2014-10-24 19:27:50]

Committed patchset #4 (id:80001) manually as
c01e405cdb1bbc1e6d50a0df95b170d29c87f652 (presubmit successful).