athena/extensions/shell/athena_shell_scheme_classifier.h - Issue 641683003: C++11 override style change for athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/shell/athena_shell_scheme_classifier.h

Issue 641683003: C++11 override style change for athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/extensions/shell/athena_shell_scheme_classifier.h

diff --git a/athena/extensions/shell/athena_shell_scheme_classifier.h b/athena/extensions/shell/athena_shell_scheme_classifier.h

index 4ab5dd7ffdc55f8d4e81bde7894a7f14bb84fd4d..98305abe69938a02aeed1c502a9213982447b556 100644

--- a/athena/extensions/shell/athena_shell_scheme_classifier.h

+++ b/athena/extensions/shell/athena_shell_scheme_classifier.h

@@ -14,10 +14,10 @@ namespace athena {

class AthenaShellSchemeClassifier : public AutocompleteSchemeClassifier {

public:

AthenaShellSchemeClassifier();

- virtual ~AthenaShellSchemeClassifier();

+ ~AthenaShellSchemeClassifier() override;

// AutocompleteSchemeClassifier:

- virtual metrics::OmniboxInputType::Type GetInputTypeForScheme(

+ metrics::OmniboxInputType::Type GetInputTypeForScheme(

const std::string& scheme) const override;

private: