Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: athena/content/web_contents_view_delegate_factory_impl.cc

Issue 641683003: C++11 override style change for athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/content/web_activity.cc ('k') | athena/env/athena_env_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/content/web_contents_view_delegate_factory_impl.cc
diff --git a/athena/content/web_contents_view_delegate_factory_impl.cc b/athena/content/web_contents_view_delegate_factory_impl.cc
index 410a39e356f6c51165fe6096a029d52ccda46726..3346aee3ccc7dfbe31d75f5aa0e3aaa007685d71 100644
--- a/athena/content/web_contents_view_delegate_factory_impl.cc
+++ b/athena/content/web_contents_view_delegate_factory_impl.cc
@@ -24,15 +24,15 @@ class WebContentsViewDelegateImpl : public content::WebContentsViewDelegate {
public:
explicit WebContentsViewDelegateImpl(content::WebContents* web_contents)
: web_contents_(web_contents) {}
- virtual ~WebContentsViewDelegateImpl() {}
+ ~WebContentsViewDelegateImpl() override {}
- virtual content::WebDragDestDelegate* GetDragDestDelegate() override {
+ content::WebDragDestDelegate* GetDragDestDelegate() override {
// TODO(oshima): crbug.com/401610
NOTIMPLEMENTED();
return nullptr;
}
- virtual bool Focus() override {
+ bool Focus() override {
web_modal::PopupManager* popup_manager =
web_modal::PopupManager::FromWebContents(web_contents_);
if (popup_manager)
@@ -40,19 +40,18 @@ class WebContentsViewDelegateImpl : public content::WebContentsViewDelegate {
return false;
}
- virtual void ShowContextMenu(
- content::RenderFrameHost* render_frame_host,
- const content::ContextMenuParams& params) override {
+ void ShowContextMenu(content::RenderFrameHost* render_frame_host,
+ const content::ContextMenuParams& params) override {
ShowMenu(BuildMenu(
content::WebContents::FromRenderFrameHost(render_frame_host), params));
}
- virtual void SizeChanged(const gfx::Size& size) override {
+ void SizeChanged(const gfx::Size& size) override {
// TODO(oshima|sadrul): Implement this when sad_tab is componentized.
// See c/b/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
}
- virtual void ShowDisambiguationPopup(
+ void ShowDisambiguationPopup(
const gfx::Rect& target_rect,
const SkBitmap& zoomed_bitmap,
const gfx::NativeView content,
@@ -61,7 +60,7 @@ class WebContentsViewDelegateImpl : public content::WebContentsViewDelegate {
NOTIMPLEMENTED();
}
- virtual void HideDisambiguationPopup() override { NOTIMPLEMENTED(); }
+ void HideDisambiguationPopup() override { NOTIMPLEMENTED(); }
scoped_ptr<RenderViewContextMenuImpl> BuildMenu(
content::WebContents* web_contents,
« no previous file with comments | « athena/content/web_activity.cc ('k') | athena/env/athena_env_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698