athena/extensions/chrome/athena_extension_install_ui.cc - Issue 641683003: C++11 override style change for athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/chrome/athena_extension_install_ui.cc

Issue 641683003: C++11 override style change for athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/extensions/chrome/athena_extension_install_ui.cc

diff --git a/athena/extensions/chrome/athena_extension_install_ui.cc b/athena/extensions/chrome/athena_extension_install_ui.cc

index a23807ca4b3c38616e4b29cd76abd8668f09038b..a11f41cfc024dba87b28fdc1f8a01e012816b34b 100644

--- a/athena/extensions/chrome/athena_extension_install_ui.cc

+++ b/athena/extensions/chrome/athena_extension_install_ui.cc

@@ -25,12 +25,12 @@ class MessageDialogDelegate : public views::DialogDelegateView {

explicit MessageDialogDelegate(const base::string16& message)

: message_(message) {}

- virtual ~MessageDialogDelegate() {}

+ ~MessageDialogDelegate() override {}

// views::DialogDelegateView:

- virtual base::string16 GetWindowTitle() const override { return message_; }

+ base::string16 GetWindowTitle() const override { return message_; }

- virtual int GetDialogButtons() const override { return ui::DIALOG_BUTTON_OK; }

+ int GetDialogButtons() const override { return ui::DIALOG_BUTTON_OK; }

private:

base::string16 message_;