athena/extensions/athena_app_delegate_base.cc - Issue 641683003: C++11 override style change for athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/athena_app_delegate_base.cc

Issue 641683003: C++11 override style change for athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/extensions/athena_app_delegate_base.cc

diff --git a/athena/extensions/athena_app_delegate_base.cc b/athena/extensions/athena_app_delegate_base.cc

index 49b8e6d666123188958f51d2d8a52e30ebc850b4..1254a6f30c10cb93114e9a8275fab59eefaa3542 100644

--- a/athena/extensions/athena_app_delegate_base.cc

+++ b/athena/extensions/athena_app_delegate_base.cc

@@ -36,10 +36,10 @@ class AthenaAppDelegateBase::NewActivityContentsDelegate

: public content::WebContentsDelegate {

public:

NewActivityContentsDelegate() {}

- virtual ~NewActivityContentsDelegate() {}

+ ~NewActivityContentsDelegate() override {}

// content::WebContentsDelegate:

- virtual content::WebContents* OpenURLFromTab(

+ content::WebContents* OpenURLFromTab(

content::WebContents* source,

const content::OpenURLParams& params) override {

if (!source)