Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
CC:
ben+ash_chromium.org, chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Breakpad Linux: Do not use std::string in a compromised context. Committed: https://crrev.com/2d3f80d4e3f6314999488678e78dbab15d16bb7e Cr-Commit-Position: refs/heads/master@{#298598}

Patch Set 1 #

Patch Set 2 : fix content shell too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M chrome/app/chrome_crash_reporter_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/app/breakpad_linux.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M components/crash/app/crash_reporter_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/crash/app/crash_reporter_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Lei Zhang
6 years, 2 months ago (2014-10-07 02:13:35 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-07 11:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633833002/1
6 years, 2 months ago (2014-10-07 18:57:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/10784) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/22540)
6 years, 2 months ago (2014-10-07 19:20:01 UTC) #7
Lei Zhang
On 2014/10/07 19:20:01, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-07 20:26:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633833002/20001
6 years, 2 months ago (2014-10-07 20:29:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7a24b6cc83e2a6b5f5a08d34497619da97cccaab
6 years, 2 months ago (2014-10-07 22:53:32 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 22:54:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d3f80d4e3f6314999488678e78dbab15d16bb7e
Cr-Commit-Position: refs/heads/master@{#298598}

Powered by Google App Engine
This is Rietveld 408576698