Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: content/shell/app/shell_crash_reporter_client.h

Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix content shell too Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_ 5 #ifndef CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_
6 #define CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_ 6 #define CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "components/crash/app/crash_reporter_client.h" 9 #include "components/crash/app/crash_reporter_client.h"
10 10
(...skipping 10 matching lines...) Expand all
21 virtual void GetProductNameAndVersion(const base::FilePath& exe_path, 21 virtual void GetProductNameAndVersion(const base::FilePath& exe_path,
22 base::string16* product_name, 22 base::string16* product_name,
23 base::string16* version, 23 base::string16* version,
24 base::string16* special_build, 24 base::string16* special_build,
25 base::string16* channel_name) OVERRIDE; 25 base::string16* channel_name) OVERRIDE;
26 #endif 26 #endif
27 27
28 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS) 28 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)
29 // Returns a textual description of the product type and version to include 29 // Returns a textual description of the product type and version to include
30 // in the crash report. 30 // in the crash report.
31 virtual void GetProductNameAndVersion(std::string* product_name, 31 virtual void GetProductNameAndVersion(const char** product_name,
32 std::string* version) OVERRIDE; 32 const char** version) OVERRIDE;
33 33
34 virtual base::FilePath GetReporterLogFilename() OVERRIDE; 34 virtual base::FilePath GetReporterLogFilename() OVERRIDE;
35 #endif 35 #endif
36 36
37 // The location where minidump files should be written. Returns true if 37 // The location where minidump files should be written. Returns true if
38 // |crash_dir| was set. 38 // |crash_dir| was set.
39 virtual bool GetCrashDumpLocation(base::FilePath* crash_dir) OVERRIDE; 39 virtual bool GetCrashDumpLocation(base::FilePath* crash_dir) OVERRIDE;
40 40
41 #if defined(OS_ANDROID) 41 #if defined(OS_ANDROID)
42 // Returns the descriptor key of the android minidump global descriptor. 42 // Returns the descriptor key of the android minidump global descriptor.
43 virtual int GetAndroidMinidumpDescriptor() OVERRIDE; 43 virtual int GetAndroidMinidumpDescriptor() OVERRIDE;
44 #endif 44 #endif
45 45
46 virtual bool EnableBreakpadForProcess( 46 virtual bool EnableBreakpadForProcess(
47 const std::string& process_type) OVERRIDE; 47 const std::string& process_type) OVERRIDE;
48 48
49 private: 49 private:
50 DISALLOW_COPY_AND_ASSIGN(ShellCrashReporterClient); 50 DISALLOW_COPY_AND_ASSIGN(ShellCrashReporterClient);
51 }; 51 };
52 52
53 } // namespace content 53 } // namespace content
54 54
55 #endif // CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_ 55 #endif // CONTENT_SHELL_APP_SHELL_CRASH_REPORTER_CLIENT_H_
OLDNEW
« no previous file with comments | « components/crash/app/crash_reporter_client.cc ('k') | content/shell/app/shell_crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698