content/shell/app/shell_crash_reporter_client.h - Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/app/shell_crash_reporter_client.h

Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix content shell too Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/app/shell_crash_reporter_client.h

diff --git a/content/shell/app/shell_crash_reporter_client.h b/content/shell/app/shell_crash_reporter_client.h

index 1ab416da520450c59c6f342bdcf21f67d7804578..3be19a71875850f8221bd6cb5f554f6f02659d3f 100644

--- a/content/shell/app/shell_crash_reporter_client.h

+++ b/content/shell/app/shell_crash_reporter_client.h

@@ -28,8 +28,8 @@ class ShellCrashReporterClient : public crash_reporter::CrashReporterClient {

#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)

// Returns a textual description of the product type and version to include

// in the crash report.

- virtual void GetProductNameAndVersion(std::string* product_name,

- std::string* version) OVERRIDE;

+ virtual void GetProductNameAndVersion(const char** product_name,

+ const char** version) OVERRIDE;

virtual base::FilePath GetReporterLogFilename() OVERRIDE;

#endif

« no previous file with comments | « components/crash/app/crash_reporter_client.cc ('k') | content/shell/app/shell_crash_reporter_client.cc » ('j') | no next file with comments »