Breakpad Linux: Do not use std::string in a compromised context.

components/crash/app/breakpad_linux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // For linux_syscall_support.h. This makes it safe to call embedded system
 // calls when in seccomp mode.
 
 #include "components/crash/app/breakpad_linux.h"
 
 #include <fcntl.h>
@@ skipping 1295 matching lines @@
   //   Content-Type: application/octet-stream \r\n \r\n
   //   <dump contents>
   //   \r\n BOUNDARY -- \r\n
 
 #if defined(OS_CHROMEOS)
   CrashReporterWriter writer(temp_file_fd);
 #else
   MimeWriter writer(temp_file_fd, mime_boundary);
 #endif
   {
-    // TODO(thestig) Do not use this inside a compromised context.
-    std::string product_name;
-    std::string version;
+    const char* product_name = "";
+    const char* version = "";
 
     GetCrashReporterClient()->GetProductNameAndVersion(&product_name, &version);
 
     writer.AddBoundary();
-    writer.AddPairString("prod", product_name.c_str());
+    writer.AddPairString("prod", product_name);
     writer.AddBoundary();
-    writer.AddPairString("ver", version.c_str());
+    writer.AddPairString("ver", version);
     writer.AddBoundary();
     if (info.pid > 0) {
       char pid_value_buf[kUint64StringSize];
       uint64_t pid_value_len = my_uint64_len(info.pid);
       my_uint64tos(pid_value_buf, info.pid, pid_value_len);
       static const char pid_key_name[] = "pid";
       writer.AddPairData(pid_key_name, sizeof(pid_key_name) - 1,
                          pid_value_buf, pid_value_len);
       writer.AddBoundary();
     }
@@ skipping 279 matching lines @@
     }
   }
 }
 #endif  // OS_ANDROID
 
 bool IsCrashReporterEnabled() {
   return g_is_crash_reporter_enabled;
 }
 
 }  // namespace breakpad