chrome/app/chrome_crash_reporter_client.cc - Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix content shell too Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_crash_reporter_client.cc

diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc

index 6bfbb3b8c5c262cf6ea946f6dfbbd750ce0542d9..4773e7b4a0b7a8aae45035a7de104da0286f4d86 100644

--- a/chrome/app/chrome_crash_reporter_client.cc

+++ b/chrome/app/chrome_crash_reporter_client.cc

@@ -285,8 +285,8 @@ bool ChromeCrashReporterClient::ReportingIsEnforcedByPolicy(

#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)

void ChromeCrashReporterClient::GetProductNameAndVersion(

- std::string* product_name,

- std::string* version) {

+ const char** product_name,

+ const char** version) {

DCHECK(product_name);

DCHECK(version);

#if defined(OS_ANDROID)

« no previous file with comments | « chrome/app/chrome_crash_reporter_client.h ('k') | components/crash/app/breakpad_linux.cc » ('j') | no next file with comments »