Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: content/shell/app/shell_crash_reporter_client.cc

Issue 633833002: Breakpad Linux: Do not use std::string in a compromised context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix content shell too Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/app/shell_crash_reporter_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/app/shell_crash_reporter_client.h" 5 #include "content/shell/app/shell_crash_reporter_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 18 matching lines...) Expand all
29 base::string16* channel_name) { 29 base::string16* channel_name) {
30 *product_name = base::ASCIIToUTF16("content_shell"); 30 *product_name = base::ASCIIToUTF16("content_shell");
31 *version = base::ASCIIToUTF16(CONTENT_SHELL_VERSION); 31 *version = base::ASCIIToUTF16(CONTENT_SHELL_VERSION);
32 *special_build = base::string16(); 32 *special_build = base::string16();
33 *channel_name = base::string16(); 33 *channel_name = base::string16();
34 } 34 }
35 #endif 35 #endif
36 36
37 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS) 37 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)
38 void ShellCrashReporterClient::GetProductNameAndVersion( 38 void ShellCrashReporterClient::GetProductNameAndVersion(
39 std::string* product_name, 39 const char** product_name,
40 std::string* version) { 40 const char** version) {
41 *product_name = "content_shell"; 41 *product_name = "content_shell";
42 *version = CONTENT_SHELL_VERSION; 42 *version = CONTENT_SHELL_VERSION;
43 } 43 }
44 44
45 base::FilePath ShellCrashReporterClient::GetReporterLogFilename() { 45 base::FilePath ShellCrashReporterClient::GetReporterLogFilename() {
46 return base::FilePath(FILE_PATH_LITERAL("uploads.log")); 46 return base::FilePath(FILE_PATH_LITERAL("uploads.log"));
47 } 47 }
48 #endif 48 #endif
49 49
50 bool ShellCrashReporterClient::GetCrashDumpLocation(base::FilePath* crash_dir) { 50 bool ShellCrashReporterClient::GetCrashDumpLocation(base::FilePath* crash_dir) {
(...skipping 13 matching lines...) Expand all
64 bool ShellCrashReporterClient::EnableBreakpadForProcess( 64 bool ShellCrashReporterClient::EnableBreakpadForProcess(
65 const std::string& process_type) { 65 const std::string& process_type) {
66 return process_type == switches::kRendererProcess || 66 return process_type == switches::kRendererProcess ||
67 process_type == switches::kPluginProcess || 67 process_type == switches::kPluginProcess ||
68 process_type == switches::kPpapiPluginProcess || 68 process_type == switches::kPpapiPluginProcess ||
69 process_type == switches::kZygoteProcess || 69 process_type == switches::kZygoteProcess ||
70 process_type == switches::kGpuProcess; 70 process_type == switches::kGpuProcess;
71 } 71 }
72 72
73 } // namespace content 73 } // namespace content
OLDNEW
« no previous file with comments | « content/shell/app/shell_crash_reporter_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698