Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 630853002: Replacing the OVERRIDE with override in third_party/WebKit/Source/platform (Closed)

Created:
6 years, 2 months ago by ARUNKK
Modified:
6 years, 2 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, shans, vikasa, dcheng, Steve Block, rwlbuis, jamesr, pdr+graphicswatchlist_chromium.org, skal, danakj, dstockwell, Timothy Loh, Rik, Eric Willigers, rjwright, Mads Ager (chromium), jbroman, Raymond Toy, tommyw+watchlist_chromium.org, krit, darktears, jzern, blink-reviews-animation_chromium.org, mkwst+moarreviews_chromium.org, blink-layers+watch_chromium.org, Mike Lawther (Google), urvang (Google), Stephen Chennney, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in third_party/WebKit/Source/platform This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183409

Patch Set 1 #

Patch Set 2 : Rebase issue #

Patch Set 3 : Rebase build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1023 lines, -1023 lines) Patch
M Source/platform/DragImageTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/JSONValues.h View 6 chunks +17 lines, -17 lines 0 comments Download
M Source/platform/LifecycleContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODArena.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/PODIntervalTree.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/RefCountedSupplement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/SharedTimer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/Task.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/TestingPlatformSupport.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/Timer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/TracedValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/UserGestureIndicator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/animation/AnimationValue.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/animation/TimingFunction.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/audio/AudioDSPKernelProcessor.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/platform/audio/AudioDelayDSPKernel.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/audio/AudioDestination.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/audio/EqualPowerPanner.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/audio/HRTFPanner.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/audio/MultiChannelResampler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/SincResampler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blob/BlobRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebScrollbarImpl.h View 1 chunk +19 lines, -19 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +34 lines, -34 lines 0 comments Download
M Source/platform/exported/WebScrollbarThemeGeometryNative.h View 1 chunk +17 lines, -17 lines 0 comments Download
M Source/platform/fonts/FontCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GlyphBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GlyphBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GlyphPageTreeNodeTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/SegmentedFontData.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/geometry/FloatPolygon.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/BitmapImage.h View 6 chunks +19 lines, -19 lines 0 comments Download
M Source/platform/graphics/BitmapImageTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/BitmapPattern.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/BitmapPatternBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 1 chunk +11 lines, -11 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerManager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/Canvas2DLayerManagerTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/ContentLayerDelegate.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/DecodingImageGenerator.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoderTest.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/graphics/GeneratedImage.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/GraphicsLayerDebugInfo.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayerTest.cpp View 2 chunks +21 lines, -21 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStore.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageFrameGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageFrameGeneratorTest.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/graphics/InterceptingCanvas.h View 1 chunk +34 lines, -34 lines 0 comments Download
M Source/platform/graphics/LoggingCanvas.h View 1 chunk +33 lines, -33 lines 0 comments Download
M Source/platform/graphics/ProfilingCanvas.h View 1 chunk +33 lines, -33 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/graphics/ReplayingCanvas.h View 1 chunk +34 lines, -34 lines 0 comments Download
M Source/platform/graphics/StaticBitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/StaticBitmapPattern.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/UnacceleratedImageBufferSurface.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/DistantLightSource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/filters/FEBlend.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEColorMatrix.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEComposite.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/filters/FEConvolveMatrix.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEDiffuseLighting.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/filters/FEDropShadow.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEFlood.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/FELighting.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEMerge.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEMorphology.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FEOffset.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/filters/FESpecularLighting.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FETile.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/FETurbulence.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FilterOperation.h View 6 chunks +17 lines, -17 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/ReferenceFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/SourceAlpha.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/SourceGraphic.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/gpu/WebGLImageBufferSurface.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/graphics/test/MockImageDecoder.h View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/heap/Handle.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Heap.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 5 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 10 chunks +21 lines, -21 lines 0 comments Download
M Source/platform/heap/Visitor.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/heap/glue/MessageLoopInterruptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/image-decoders/ImageDecoderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/image-decoders/bmp/BMPImageDecoder.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/gif/GIFImageDecoder.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/image-decoders/ico/ICOImageDecoder.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/webp/WEBPImageDecoder.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.h View 1 chunk +39 lines, -39 lines 0 comments Download
M Source/platform/mac/ScrollElasticityControllerTest.mm View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/platform/mediastream/MediaStreamCenter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamWebAudioSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/plugins/PluginListBuilder.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/scheduler/Scheduler.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/scheduler/SchedulerTest.cpp View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/scroll/ScrollView.h View 1 9 chunks +33 lines, -33 lines 0 comments Download
M Source/platform/scroll/Scrollbar.h View 1 4 chunks +40 lines, -40 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMock.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeNonMacCommon.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlayMock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/testing/ArenaTestHelpers.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/text/DateTimeFormatTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/text/LineEnding.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/text/LocaleICU.h View 1 chunk +16 lines, -16 lines 0 comments Download
M Source/platform/text/LocaleMac.h View 1 chunk +16 lines, -16 lines 0 comments Download
M Source/platform/text/LocaleWin.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/platform/text/PlatformLocale.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/transforms/IdentityTransformOperation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/InterpolatedTransformOperation.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/transforms/Matrix3DTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/MatrixTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/PerspectiveTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/RotateTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/ScaleTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/SkewTransformOperation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/transforms/TranslateTransformOperation.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/weborigin/KURL.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
ARUNKK
PTAL
6 years, 2 months ago (2014-10-07 13:41:48 UTC) #2
haraken
rubberstamp LGTM.
6 years, 2 months ago (2014-10-07 13:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630853002/1
6 years, 2 months ago (2014-10-07 13:55:12 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/platform/heap/Visitor.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-07 13:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630853002/20001
6 years, 2 months ago (2014-10-08 09:56:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/30710)
6 years, 2 months ago (2014-10-08 10:23:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630853002/40001
6 years, 2 months ago (2014-10-08 10:35:57 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 11:46:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183409

Powered by Google App Engine
This is Rietveld 408576698