Issue 62163004: Added support for Chrome's gpu command buffer extension BindUniformLocation.

Issue 62163004: Added support for Chrome's gpu command buffer extension BindUniformLocation. (Closed)

Created:
7 years, 1 month ago by slavi

Modified:
7 years, 1 month ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Added support for Chrome's gpu command buffer extension BindUniformLocation. R=bsalomon Committed: http://code.google.com/p/skia/source/detail?r=12178

Patch Set 3 : Fixed compile error on the bots + feedback. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -52 lines)			Patch
M	include/gpu/gl/GrGLFunctions.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkColorFilters.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/gradients/SkTwoPointRadialGradient.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrBicubicEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLUniformManager.h	View		3 chunks	+16 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLUniformManager.cpp	View		7 chunks	+32 lines, -27 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bsalomon

mostly looks good, I think the bot failures indicate that a uniform set function was ...

7 years, 1 month ago (2013-11-07 15:06:59 UTC) #2

slavi

https://codereview.chromium.org/62163004/diff/60001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/62163004/diff/60001/src/gpu/gl/GrGpuGL.cpp#newcode126 src/gpu/gl/GrGpuGL.cpp:126: #ifdef SK_DEBUG On 2013/11/07 15:06:59, bsalomon wrote: > Can ...

7 years, 1 month ago (2013-11-07 20:53:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/skaslev@chromium.org/62163004/140001

7 years, 1 month ago (2013-11-07 21:55:21 UTC) #5

Message was sent while issue was closed.

Change committed as 12178

Expand Messages | Collapse Messages