src/effects/SkLightingImageFilter.cpp - Issue 62163004: Added support for Chrome's gpu command buffer extension BindUniformLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 62163004: Added support for Chrome's gpu command buffer extension BindUniformLocation. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Fixed compile error on the bots + feedback. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index dd23532e71e832994b2a9921fce13a52132e5b33..db3a1a0924c402d0fb20803f71fb48fb2a25d34e 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -36,7 +36,7 @@ const SkScalar gOneQuarter = SkFloatToScalar(0.25f);

#if SK_SUPPORT_GPU

void setUniformPoint3(const GrGLUniformManager& uman, UniformHandle uni, const SkPoint3& point) {

GR_STATIC_ASSERT(sizeof(SkPoint3) == 3 * sizeof(GrGLfloat));

- uman.set3fv(uni, 0, 1, &point.fX);

+ uman.set3fv(uni, 1, &point.fX);

}

void setUniformNormal3(const GrGLUniformManager& uman, UniformHandle uni, const SkPoint3& point) {

« no previous file with comments | « src/effects/SkColorMatrixFilter.cpp ('k') | src/effects/SkMatrixConvolutionImageFilter.cpp » ('j') | no next file with comments »