Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 616283002: Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/" (Closed)

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
Reviewers:
Sunil Ratnu
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/" This reverts commit ebd89062890217392ba453bea3629d0e1e19eaea. I suspect this has collided with https://codereview.chromium.org/613143003/ or its revert and is causing some persistent compile failures on the Webkit GPU Mac Builder link: http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil... errors like: FAILED: /Volumes/data/b/build/goma/gomacc Undefined symbols for architecture i386: "__ZN16password_manager14CredentialInfoC1ERKN8autofill12PasswordFormE", referenced from: __ZN16password_manager34ContentCredentialManagerDispatcher25OnGetPasswordStoreResultsERKSt6vectorIPN8autofill12PasswordFormESaIS4_EE in libpassword_manager_content_browser.a(password_manager_content_browser.content_credential_manager_dispatcher.o) R=sunil.ratnu@samsung.com BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -118 lines) Patch
M components/password_manager/content/browser/content_credential_manager_dispatcher.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.h View 1 chunk +14 lines, -14 lines 0 comments Download
M components/password_manager/content/browser/password_manager_internals_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/renderer/credential_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/browser_save_password_progress_logger.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_generation_manager_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M components/password_manager/core/browser/password_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_store.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_default.h View 1 chunk +11 lines, -11 lines 0 comments Download
M components/password_manager/core/browser/password_store_default_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_syncable_service.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/stub_password_manager_client.h View 1 chunk +8 lines, -8 lines 0 comments Download
M components/password_manager/core/browser/stub_password_manager_driver.h View 1 chunk +12 lines, -12 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.h View 1 chunk +12 lines, -12 lines 0 comments Download
M components/password_manager/core/browser/webdata/logins_table.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tapted
6 years, 2 months ago (2014-10-01 08:13:04 UTC) #1
tapted
6 years, 2 months ago (2014-10-01 08:17:27 UTC) #2 
Looking at the diff.. I'm pretty certain this won't solve anything. Closing.

Powered by Google App Engine
This is Rietveld 408576698