components/password_manager/core/browser/password_store_default.h - Issue 616283002: Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.h

Issue 616283002: Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store.h ('k') | components/password_manager/core/browser/password_store_default_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default.h

diff --git a/components/password_manager/core/browser/password_store_default.h b/components/password_manager/core/browser/password_store_default.h

index f60183f0fac8e2ebc3b085ddc62ba015335a60ea..6de86fa9d860d0f4cd8d1c0f93145bd37dcb01f2 100644

--- a/components/password_manager/core/browser/password_store_default.h

+++ b/components/password_manager/core/browser/password_store_default.h

@@ -27,29 +27,29 @@ class PasswordStoreDefault : public PasswordStore {

virtual ~PasswordStoreDefault();

// Implements PasswordStore interface.

- virtual void ReportMetricsImpl(const std::string& sync_username) override;

+ virtual void ReportMetricsImpl(const std::string& sync_username) OVERRIDE;

virtual PasswordStoreChangeList AddLoginImpl(

- const autofill::PasswordForm& form) override;

+ const autofill::PasswordForm& form) OVERRIDE;

virtual PasswordStoreChangeList UpdateLoginImpl(

- const autofill::PasswordForm& form) override;

+ const autofill::PasswordForm& form) OVERRIDE;

virtual PasswordStoreChangeList RemoveLoginImpl(

- const autofill::PasswordForm& form) override;

+ const autofill::PasswordForm& form) OVERRIDE;

virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(

base::Time delete_begin,

- base::Time delete_end) override;

+ base::Time delete_end) OVERRIDE;

virtual PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(

base::Time delete_begin,

- base::Time delete_end) override;

+ base::Time delete_end) OVERRIDE;

virtual void GetLoginsImpl(

const autofill::PasswordForm& form,

AuthorizationPromptPolicy prompt_policy,

- const ConsumerCallbackRunner& callback_runner) override;

- virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request) override;

- virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request) override;

+ const ConsumerCallbackRunner& callback_runner) OVERRIDE;

+ virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request) OVERRIDE;

+ virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request) OVERRIDE;

virtual bool FillAutofillableLogins(

- std::vector<autofill::PasswordForm*>* forms) override;

+ std::vector<autofill::PasswordForm*>* forms) OVERRIDE;

virtual bool FillBlacklistLogins(

- std::vector<autofill::PasswordForm*>* forms) override;

+ std::vector<autofill::PasswordForm*>* forms) OVERRIDE;

protected:

inline bool DeleteAndRecreateDatabaseFile() {