Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2132)

Side by Side Diff: components/password_manager/core/browser/password_manager.h

Issue 616283002: Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 bool IsSavingEnabledForCurrentPage() const; 67 bool IsSavingEnabledForCurrentPage() const;
68 68
69 // Called by a PasswordFormManager when it decides a form can be autofilled 69 // Called by a PasswordFormManager when it decides a form can be autofilled
70 // on the page. 70 // on the page.
71 virtual void Autofill(const autofill::PasswordForm& form_for_autofill, 71 virtual void Autofill(const autofill::PasswordForm& form_for_autofill,
72 const autofill::PasswordFormMap& best_matches, 72 const autofill::PasswordFormMap& best_matches,
73 const autofill::PasswordForm& preferred_match, 73 const autofill::PasswordForm& preferred_match,
74 bool wait_for_username) const; 74 bool wait_for_username) const;
75 75
76 // LoginModel implementation. 76 // LoginModel implementation.
77 virtual void AddObserver(LoginModelObserver* observer) override; 77 virtual void AddObserver(LoginModelObserver* observer) OVERRIDE;
78 virtual void RemoveObserver(LoginModelObserver* observer) override; 78 virtual void RemoveObserver(LoginModelObserver* observer) OVERRIDE;
79 79
80 // Mark this form as having a generated password. 80 // Mark this form as having a generated password.
81 void SetFormHasGeneratedPassword(const autofill::PasswordForm& form); 81 void SetFormHasGeneratedPassword(const autofill::PasswordForm& form);
82 82
83 // TODO(isherman): This should not be public, but is currently being used by 83 // TODO(isherman): This should not be public, but is currently being used by
84 // the LoginPrompt code. 84 // the LoginPrompt code.
85 // When a form is submitted, we prepare to save the password but wait 85 // When a form is submitted, we prepare to save the password but wait
86 // until we decide the user has successfully logged in. This is step 1 86 // until we decide the user has successfully logged in. This is step 1
87 // of 2 (see SavePassword). 87 // of 2 (see SavePassword).
88 void ProvisionallySavePassword(const autofill::PasswordForm& form); 88 void ProvisionallySavePassword(const autofill::PasswordForm& form);
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 // the recorded forms matches the login form from the previous page 201 // the recorded forms matches the login form from the previous page
202 // (to see if the login was a failure), and clears the vector. 202 // (to see if the login was a failure), and clears the vector.
203 std::vector<autofill::PasswordForm> all_visible_forms_; 203 std::vector<autofill::PasswordForm> all_visible_forms_;
204 204
205 DISALLOW_COPY_AND_ASSIGN(PasswordManager); 205 DISALLOW_COPY_AND_ASSIGN(PasswordManager);
206 }; 206 };
207 207
208 } // namespace password_manager 208 } // namespace password_manager
209 209
210 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 210 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698