Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Side by Side Diff: components/password_manager/content/browser/content_credential_manager_dispatcher.h

Issue 616283002: Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_D ISPATCHER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_D ISPATCHER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_D ISPATCHER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_D ISPATCHER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/password_manager/core/browser/credential_manager_dispatcher .h" 9 #include "components/password_manager/core/browser/credential_manager_dispatcher .h"
10 #include "components/password_manager/core/browser/password_store_consumer.h" 10 #include "components/password_manager/core/browser/password_store_consumer.h"
(...skipping 21 matching lines...) Expand all
32 public: 32 public:
33 // |client| isn't yet used by this class, but is necessary for the next step: 33 // |client| isn't yet used by this class, but is necessary for the next step:
34 // wiring this up as a subclass of PasswordStoreConsumer. 34 // wiring this up as a subclass of PasswordStoreConsumer.
35 ContentCredentialManagerDispatcher(content::WebContents* web_contents, 35 ContentCredentialManagerDispatcher(content::WebContents* web_contents,
36 PasswordManagerClient* client); 36 PasswordManagerClient* client);
37 virtual ~ContentCredentialManagerDispatcher(); 37 virtual ~ContentCredentialManagerDispatcher();
38 38
39 // CredentialManagerDispatcher implementation. 39 // CredentialManagerDispatcher implementation.
40 virtual void OnNotifyFailedSignIn( 40 virtual void OnNotifyFailedSignIn(
41 int request_id, 41 int request_id,
42 const password_manager::CredentialInfo&) override; 42 const password_manager::CredentialInfo&) OVERRIDE;
43 virtual void OnNotifySignedIn( 43 virtual void OnNotifySignedIn(
44 int request_id, 44 int request_id,
45 const password_manager::CredentialInfo&) override; 45 const password_manager::CredentialInfo&) OVERRIDE;
46 virtual void OnNotifySignedOut(int request_id) override; 46 virtual void OnNotifySignedOut(int request_id) OVERRIDE;
47 virtual void OnRequestCredential( 47 virtual void OnRequestCredential(
48 int request_id, 48 int request_id,
49 bool zero_click_only, 49 bool zero_click_only,
50 const std::vector<GURL>& federations) override; 50 const std::vector<GURL>& federations) OVERRIDE;
51 51
52 // content::WebContentsObserver implementation. 52 // content::WebContentsObserver implementation.
53 virtual bool OnMessageReceived(const IPC::Message& message) override; 53 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
54 54
55 // PasswordStoreConsumer implementation. 55 // PasswordStoreConsumer implementation.
56 virtual void OnGetPasswordStoreResults( 56 virtual void OnGetPasswordStoreResults(
57 const std::vector<autofill::PasswordForm*>& results) override; 57 const std::vector<autofill::PasswordForm*>& results) OVERRIDE;
58 58
59 private: 59 private:
60 PasswordStore* GetPasswordStore(); 60 PasswordStore* GetPasswordStore();
61 61
62 PasswordManagerClient* client_; 62 PasswordManagerClient* client_;
63 63
64 // When 'OnRequestCredential' is called, it in turn calls out to the 64 // When 'OnRequestCredential' is called, it in turn calls out to the
65 // PasswordStore; we store the request ID here in order to properly respond 65 // PasswordStore; we store the request ID here in order to properly respond
66 // to the request once the PasswordStore gives us data. 66 // to the request once the PasswordStore gives us data.
67 int pending_request_id_; 67 int pending_request_id_;
68 68
69 DISALLOW_COPY_AND_ASSIGN(ContentCredentialManagerDispatcher); 69 DISALLOW_COPY_AND_ASSIGN(ContentCredentialManagerDispatcher);
70 }; 70 };
71 71
72 } // namespace password_manager 72 } // namespace password_manager
73 73
74 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGE R_DISPATCHER_H_ 74 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGE R_DISPATCHER_H_
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698