Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

Issue 616283002: Revert "Replace OVERRIDE with its C++11 counterpart in components/password_manager/" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/renderer/credential_manager_client_browsertest.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
index 987f9d064994955d911d95e8c4f19f0672a94d21..d319a071d96ecd222bbe30c514b0ece87d74d523 100644
--- a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
+++ b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
@@ -21,13 +21,13 @@ class CredentialManagerClientTest : public content::RenderViewTest {
: callback_errored_(false), callback_succeeded_(false) {}
virtual ~CredentialManagerClientTest() {}
- virtual void SetUp() override {
+ virtual void SetUp() OVERRIDE {
content::RenderViewTest::SetUp();
credential_.reset(new blink::WebCredential("", "", GURL()));
client_.reset(new CredentialManagerClient(view_));
}
- virtual void TearDown() override {
+ virtual void TearDown() OVERRIDE {
credential_.reset();
content::RenderViewTest::TearDown();
}
@@ -112,9 +112,9 @@ class TestNotificationCallbacks
virtual ~TestNotificationCallbacks() {}
- virtual void onSuccess() { test_->set_callback_succeeded(true); }
+ virtual void onSuccess() OVERRIDE { test_->set_callback_succeeded(true); }
- virtual void onError(blink::WebCredentialManagerError* reason) {
+ virtual void onError(blink::WebCredentialManagerError* reason) OVERRIDE {
test_->set_callback_errored(true);
}
@@ -130,11 +130,11 @@ class TestRequestCallbacks
virtual ~TestRequestCallbacks() {}
- virtual void onSuccess(blink::WebCredential*) {
+ virtual void onSuccess(blink::WebCredential*) OVERRIDE {
test_->set_callback_succeeded(true);
}
- virtual void onError(blink::WebCredentialManagerError* reason) {
+ virtual void onError(blink::WebCredentialManagerError* reason) OVERRIDE {
test_->set_callback_errored(true);
}

Powered by Google App Engine
This is Rietveld 408576698