Rename Constant to ConstantValue and ConstExp to ConstantExpression.

Rename Constant to ConstantValue and ConstExp to ConstantExpression.

BUG=
R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40831

[Johnni Winther, 2014-09-30 14:03:12]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2014-10-01 07:46:48]

lgtm.

Maybe you can use this list:
Long lines:
  File
"sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart",
line 81
    ConstantExpression constExp = new
PrimitiveConstantExpression(primitiveConstant);
  File "sdk/lib/_internal/compiler/implementation/cps_ir/optimizers.dart", line
7
import '../constants/expressions.dart' show ConstantExpression,
PrimitiveConstantExpression;
  File
"sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart",
line 667
  Expression emitConstant(ConstantExpression exp) => new
ConstantEmitter(this).visit(exp);
  File
"sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart",
line 464
      Token tok = new StringToken.fromString(STRING_INFO,
'${value.primitiveValue}', -1);
  File
"sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart",
line 451
  /// Should not be null. Use [Constant] with [NullConstantValue] for void
returns.
  File "sdk/lib/_internal/compiler/implementation/deferred_load.dart", line 288
      ConstantExpression constant =
backend.constants.getConstantForMetadata(metadata);
  File "sdk/lib/_internal/compiler/implementation/deferred_load.dart", line 470
          Element element =
metadata.constant.value.computeType(compiler).element;
  File "sdk/lib/_internal/compiler/implementation/js_backend/backend.dart", line
1157
      ConstantExpression initialValue =
constants.getConstantForVariable(element);
  File "sdk/lib/_internal/compiler/implementation/js_backend/backend.dart", line
1614
        ConstantValue constant =
constants.getConstantForMetadata(metadata).value;
  File
"sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart",
line 54
class ConstantReferenceEmitter implements ConstantValueVisitor<jsAst.Expression>
{
  File
"sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart",
line 147
 * [ConstantValue]s. These can be used for inlining constants or in
initializers.
  File
"sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart",
line 245
        if (key.primitiveValue == JavaScriptMapConstant.PROTO_PROPERTY)
continue;
  File "sdk/lib/_internal/compiler/implementation/js_backend/namer.dart", line
1225
  int visitDouble(DoubleConstantValue constant) =>
_hashDouble(constant.primitiveValue);
  File
"sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart",
line 136
      outputConstantLists.putIfAbsent(constantUnit, () => new
List<ConstantValue>())
  File
"sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart",
line 50
      ConstantExpression constant =
backend.constants.getConstantForVariable(element);
  File
"sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart",
line 61
    ConstantExpression constant =
backend.constants.getConstantForMetadata(annotation);
  File
"sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart",
line 36
    Dart2JsMirrorSystem mirrorSystem, ConstantExpression constant, ConstantValue
value) {
  File
"sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart",
line 97
                            ConstantExpression constant, NullConstantValue
value)
  File "sdk/lib/_internal/compiler/implementation/resolution/members.dart", line
3312
        ConstantExpression constant =
compiler.resolver.constantCompiler.compileNode(
  File "sdk/lib/_internal/compiler/implementation/resolution/members.dart", line
3364
      ConstantExpression constant =
compiler.resolver.constantCompiler.compileNode(
  File "sdk/lib/_internal/compiler/implementation/resolution/members.dart", line
3751
        ConstantExpression constant =
registry.getConstant(caseMatch.expression);
  File "sdk/lib/_internal/compiler/implementation/ssa/builder.dart", line 2095
          ConstantValue constant = new
InterceptorConstantValue(classElement.thisType);
  File "sdk/lib/_internal/compiler/implementation/ssa/builder.dart", line 5371
  Map<ast.CaseMatch, ConstantValue> buildSwitchCaseConstants(ast.SwitchStatement
node) {
    Map<ast.CaseMatch, ConstantValue> constants = new Map<ast.CaseMatch,
ConstantValue>();
  File "sdk/lib/_internal/compiler/implementation/ssa/builder.dart", line 5386
    Map<ast.CaseMatch, ConstantValue> constants =
buildSwitchCaseConstants(node);
  File "sdk/lib/_internal/compiler/implementation/ssa/builder.dart", line 5610
                    Iterable<ConstantValue> getConstants(ast.SwitchCase
switchCase),
  File "sdk/lib/_internal/compiler/implementation/ssa/builder.dart", line 5613
    Map<ast.CaseMatch, ConstantValue> constants = new Map<ast.CaseMatch,
ConstantValue>();
  File
"sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart",
line 150
    ConstantValue constant = new
InterceptorConstantValue(constantInterceptor.thisType);
  File "sdk/lib/_internal/compiler/implementation/ssa/optimize.dart", line 828
    if (leftString != null && leftString.primitiveValue.length == 0) return
node.right;
  File "sdk/lib/_internal/compiler/implementation/ssa/optimize.dart", line 852
            new ast.DartString.concat(leftString.primitiveValue,
rightString.primitiveValue)),
  File "sdk/lib/_internal/compiler/implementation/ssa/optimize.dart", line 972
      ConstantValue constant = new DummyConstantValue(const
TypeMask.nonNullEmpty());
  File "sdk/lib/_internal/compiler/implementation/use_unused_api.dart", line 67
void useConstant(constants.ConstantValue constant, dart2jslib.ConstantSystem cs)
{

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart:81:
ConstantExpression constExp = new
PrimitiveConstantExpression(primitiveConstant);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/optimizers.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/optimizers.dart:7: import
'../constants/expressions.dart' show ConstantExpression,
PrimitiveConstantExpression;
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart:667:
Expression emitConstant(ConstantExpression exp) => new
ConstantEmitter(this).visit(exp);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart:464:
Token tok = new StringToken.fromString(STRING_INFO, '${value.primitiveValue}',
-1);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart:451:
/// Should not be null. Use [Constant] with [NullConstantValue] for void
returns.
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:470: Element
element = metadata.constant.value.computeType(compiler).element;
Not your code, but long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1614:
ConstantValue constant = constants.getConstantForMetadata(metadata).value;
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart:245:
if (key.primitiveValue == JavaScriptMapConstant.PROTO_PROPERTY) continue;
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:1225: int
visitDouble(DoubleConstantValue constant) =>
_hashDouble(constant.primitiveValue);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart:50:
ConstantExpression constant = backend.constants.getConstantForVariable(element);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart:61:
ConstantExpression constant =
backend.constants.getConstantForMetadata(annotation);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart:36:
Dart2JsMirrorSystem mirrorSystem, ConstantExpression constant, ConstantValue
value) {
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart:97:
ConstantExpression constant, NullConstantValue value)
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3312:
ConstantExpression constant = compiler.resolver.constantCompiler.compileNode(
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3364:
ConstantExpression constant = compiler.resolver.constantCompiler.compileNode(
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3751:
ConstantExpression constant = registry.getConstant(caseMatch.expression);
long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2095: ConstantValue
constant = new InterceptorConstantValue(classElement.thisType);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5371:
Map<ast.CaseMatch, ConstantValue> buildSwitchCaseConstants(ast.SwitchStatement
node) {
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5372:
Map<ast.CaseMatch, ConstantValue> constants = new Map<ast.CaseMatch,
ConstantValue>();
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5386:
Map<ast.CaseMatch, ConstantValue> constants = buildSwitchCaseConstants(node);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5610:
Iterable<ConstantValue> getConstants(ast.SwitchCase switchCase),
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5613:
Map<ast.CaseMatch, ConstantValue> constants = new Map<ast.CaseMatch,
ConstantValue>();
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:150:
ConstantValue constant = new
InterceptorConstantValue(constantInterceptor.thisType);
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:828: if (leftString
!= null && leftString.primitiveValue.length == 0) return node.right;
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:972: ConstantValue
constant = new DummyConstantValue(const TypeMask.nonNullEmpty());
Long line

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/use_unused_api.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/use_unused_api.dart:67: void
useConstant(constants.ConstantValue constant, dart2jslib.ConstantSystem cs) {
Long line

[Johnni Winther, 2014-10-01 08:21:24]

Thanks!

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart:81:
ConstantExpression constExp = new
PrimitiveConstantExpression(primitiveConstant);
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/optimizers.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/optimizers.dart:7: import
'../constants/expressions.dart' show ConstantExpression,
PrimitiveConstantExpression;
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart:667:
Expression emitConstant(ConstantExpression exp) => new
ConstantEmitter(this).visit(exp);
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart:464:
Token tok = new StringToken.fromString(STRING_INFO, '${value.primitiveValue}',
-1);
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart:451:
/// Should not be null. Use [Constant] with [NullConstantValue] for void
returns.
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/deferred_load.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/deferred_load.dart:470: Element
element = metadata.constant.value.computeType(compiler).element;
On 2014/10/01 07:46:47, sigurdm wrote:
> Not your code, but long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1614:
ConstantValue constant = constants.getConstantForMetadata(metadata).value;
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart:245:
if (key.primitiveValue == JavaScriptMapConstant.PROTO_PROPERTY) continue;
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:1225: int
visitDouble(DoubleConstantValue constant) =>
_hashDouble(constant.primitiveValue);
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart:50:
ConstantExpression constant = backend.constants.getConstantForVariable(element);
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart:61:
ConstantExpression constant =
backend.constants.getConstantForMetadata(annotation);
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart:36:
Dart2JsMirrorSystem mirrorSystem, ConstantExpression constant, ConstantValue
value) {
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart:97:
ConstantExpression constant, NullConstantValue value)
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3312:
ConstantExpression constant = compiler.resolver.constantCompiler.compileNode(
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3364:
ConstantExpression constant = compiler.resolver.constantCompiler.compileNode(
On 2014/10/01 07:46:47, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3751:
ConstantExpression constant = registry.getConstant(caseMatch.expression);
On 2014/10/01 07:46:47, sigurdm wrote:
> long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2095: ConstantValue
constant = new InterceptorConstantValue(classElement.thisType);
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5371:
Map<ast.CaseMatch, ConstantValue> buildSwitchCaseConstants(ast.SwitchStatement
node) {
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5372:
Map<ast.CaseMatch, ConstantValue> constants = new Map<ast.CaseMatch,
ConstantValue>();
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5386:
Map<ast.CaseMatch, ConstantValue> constants = buildSwitchCaseConstants(node);
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5610:
Iterable<ConstantValue> getConstants(ast.SwitchCase switchCase),
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:5613:
Map<ast.CaseMatch, ConstantValue> constants = new Map<ast.CaseMatch,
ConstantValue>();
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart
(right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:150:
ConstantValue constant = new
InterceptorConstantValue(constantInterceptor.thisType);
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:828: if (leftString
!= null && leftString.primitiveValue.length == 0) return node.right;
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:972: ConstantValue
constant = new DummyConstantValue(const TypeMask.nonNullEmpty());
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/use_unused_api.dart (right):

https://codereview.chromium.org/614993002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/use_unused_api.dart:67: void
useConstant(constants.ConstantValue constant, dart2jslib.ConstantSystem cs) {
On 2014/10/01 07:46:48, sigurdm wrote:
> Long line

Done.

[Johnni Winther, 2014-10-01 08:29:45]

Committed patchset #2 (id:20001) manually as 40831 (presubmit successful).