sdk/lib/_internal/compiler/implementation/patch_parser.dart - Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/patch_parser.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/new_js_emitter/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/patch_parser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/patch_parser.dart b/sdk/lib/_internal/compiler/implementation/patch_parser.dart

index ef29b405e905e68b02be1ab6703c3fac48be19b6..0899be3419411bc66fd745de6ce41499c0ae0651 100644

--- a/sdk/lib/_internal/compiler/implementation/patch_parser.dart

+++ b/sdk/lib/_internal/compiler/implementation/patch_parser.dart

@@ -116,7 +116,7 @@ library patchparser;

import 'dart:async';

-import 'constants/values.dart' show Constant;

+import 'constants/values.dart' show ConstantValue;

import 'dart2jslib.dart'

show Compiler,

CompilerTask,

@@ -317,7 +317,7 @@ abstract class EagerAnnotationHandler {

void validate(Compiler compiler,

Element element,

MetadataAnnotation annotation,

- Constant constant);

+ ConstantValue constant);

/// Checks [element] for metadata matching the [handler]. Return `true` if

@@ -378,7 +378,7 @@ class NativeAnnotationHandler implements EagerAnnotationHandler {

void validate(Compiler compiler,

Element element,

MetadataAnnotation annotation,

- Constant constant) {

+ ConstantValue constant) {

if (constant.computeType(compiler).element !=

compiler.nativeAnnotationClass) {

compiler.internalError(annotation, 'Invalid @Native(...) annotation.');

@@ -404,7 +404,7 @@ class PatchAnnotationHandler implements EagerAnnotationHandler {

void validate(Compiler compiler,

Element element,

MetadataAnnotation annotation,

- Constant constant) {

+ ConstantValue constant) {

if (constant != compiler.patchConstant) {

compiler.internalError(annotation, 'Invalid patch annotation.');

}