Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/container_builder.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/container_builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/container_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/container_builder.dart
index d04357e334e867941f5a72a993b2accffb5b93f4..9c07202d286db3a475e0cee37bf81d5fe50cdf94 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/container_builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/container_builder.dart
@@ -96,12 +96,12 @@ class ContainerBuilder extends CodeEmitterHelper {
parametersBuffer[optionalParameterStart + index] =
new jsAst.Parameter(jsName);
} else {
- ConstExp constant = handler.getConstantForVariable(element);
+ ConstantExpression constant = handler.getConstantForVariable(element);
if (constant == null) {
argumentsBuffer[count] =
- emitter.constantReference(new NullConstant());
+ emitter.constantReference(new NullConstantValue());
} else {
- Constant value = constant.value;
+ ConstantValue value = constant.value;
if (!value.isNull) {
// If the value is the null constant, we should not pass it
// down to the native method.
@@ -517,7 +517,7 @@ class ContainerBuilder extends CodeEmitterHelper {
if (backend.mustRetainMetadata) {
Iterable<int> metadataIndices =
parameter.metadata.map((MetadataAnnotation annotation) {
- Constant constant =
+ ConstantValue constant =
backend.constants.getConstantForMetadata(annotation).value;
backend.constants.addCompileTimeConstantForEmission(constant);
return emitter.metadataEmitter.reifyMetadata(annotation);

Powered by Google App Engine
This is Rietveld 408576698