Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart
index 08b7212a264350b94af7bb6d6ba0d05c8c5d32ef..8c9ef74b8079691b3069f52104df34b259f441c3 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/metadata_emitter.dart
@@ -27,7 +27,7 @@ class MetadataEmitter extends CodeEmitterHelper {
if (link != null) {
for (; !link.isEmpty; link = link.tail) {
MetadataAnnotation annotation = link.head;
- ConstExp constant =
+ ConstantExpression constant =
backend.constants.getConstantForMetadata(annotation);
if (constant == null) {
compiler.internalError(annotation, 'Annotation value is null.');
@@ -46,8 +46,9 @@ class MetadataEmitter extends CodeEmitterHelper {
FunctionSignature signature = function.functionSignature;
if (signature.optionalParameterCount == 0) return const [];
List<int> defaultValues = <int>[];
- for (Element element in signature.optionalParameters) {
- ConstExp constant = backend.constants.getConstantForVariable(element);
+ for (ParameterElement element in signature.optionalParameters) {
+ ConstantExpression constant =
+ backend.constants.getConstantForVariable(element);
String stringRepresentation = (constant == null)
? "null"
: jsAst.prettyPrint(
@@ -58,7 +59,8 @@ class MetadataEmitter extends CodeEmitterHelper {
}
int reifyMetadata(MetadataAnnotation annotation) {
- ConstExp constant = backend.constants.getConstantForMetadata(annotation);
+ ConstantExpression constant =
+ backend.constants.getConstantForMetadata(annotation);
if (constant == null) {
compiler.internalError(annotation, 'Annotation value is null.');
return -1;
@@ -74,7 +76,8 @@ class MetadataEmitter extends CodeEmitterHelper {
type,
(variable) {
return js.number(
- emitter.typeVariableHandler.reifyTypeVariable(variable.element));
+ emitter.typeVariableHandler.reifyTypeVariable(
+ variable.element));
},
(TypedefType typedef) {
return backend.isAccessibleByReflection(typedef.element);

Powered by Google App Engine
This is Rietveld 408576698