Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: sdk/lib/_internal/compiler/implementation/constant_system.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/constant_system.dart
diff --git a/sdk/lib/_internal/compiler/implementation/constant_system.dart b/sdk/lib/_internal/compiler/implementation/constant_system.dart
index 868ffe2aba04ec657a47553ab5f288289dd4c0df..110efca1e61750876ff987ff332a81687540c682 100644
--- a/sdk/lib/_internal/compiler/implementation/constant_system.dart
+++ b/sdk/lib/_internal/compiler/implementation/constant_system.dart
@@ -10,12 +10,12 @@ abstract class Operation {
abstract class UnaryOperation extends Operation {
/** Returns [:null:] if it was unable to fold the operation. */
- Constant fold(Constant constant);
+ ConstantValue fold(ConstantValue constant);
}
abstract class BinaryOperation extends Operation {
/** Returns [:null:] if it was unable to fold the operation. */
- Constant fold(Constant left, Constant right);
+ ConstantValue fold(ConstantValue left, ConstantValue right);
apply(left, right);
}
@@ -48,28 +48,30 @@ abstract class ConstantSystem {
const ConstantSystem();
- Constant createInt(int i);
- Constant createDouble(double d);
- Constant createString(DartString string);
- Constant createBool(bool value);
- Constant createNull();
- Constant createMap(Compiler compiler, InterfaceType type,
- List<Constant> keys, List<Constant> values);
+ ConstantValue createInt(int i);
+ ConstantValue createDouble(double d);
+ ConstantValue createString(DartString string);
+ ConstantValue createBool(bool value);
+ ConstantValue createNull();
+ ConstantValue createMap(Compiler compiler,
+ InterfaceType type,
+ List<ConstantValue> keys,
+ List<ConstantValue> values);
// We need to special case the subtype check for JavaScript constant
// system because an int is a double at runtime.
bool isSubtype(Compiler compiler, DartType s, DartType t);
/** Returns true if the [constant] is an integer at runtime. */
- bool isInt(Constant constant);
+ bool isInt(ConstantValue constant);
/** Returns true if the [constant] is a double at runtime. */
- bool isDouble(Constant constant);
+ bool isDouble(ConstantValue constant);
/** Returns true if the [constant] is a string at runtime. */
- bool isString(Constant constant);
+ bool isString(ConstantValue constant);
/** Returns true if the [constant] is a boolean at runtime. */
- bool isBool(Constant constant);
+ bool isBool(ConstantValue constant);
/** Returns true if the [constant] is null at runtime. */
- bool isNull(Constant constant);
+ bool isNull(ConstantValue constant);
UnaryOperation lookupUnary(String operator) {
switch (operator) {

Powered by Google App Engine
This is Rietveld 408576698