sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart - Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart

Issue 614993002: Rename Constant to ConstantValue and ConstExp to ConstantExpression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/logical_rewriter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart

index 7ac3f9778654ed1168b750ff1e65706dd4fce0d3..bef3665f52e89c194096d77bb26445a7c073988d 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart

@@ -460,20 +460,21 @@ class TreePrinter {

bracketList(',', [makeExpression(exp.index)]));

} else if (exp is Literal) {

precedence = CALLEE;

- values.PrimitiveConstant value = exp.value;

- Token tok = new StringToken.fromString(STRING_INFO, '${value.value}', -1);

+ values.PrimitiveConstantValue value = exp.value;

+ Token tok = new StringToken.fromString(

+ STRING_INFO, '${value.primitiveValue}', -1);

if (value.isString) {

result = unparseStringLiteral(exp);

} else if (value.isInt) {

result = new tree.LiteralInt(tok, null);

} else if (value.isDouble) {

- if (value.value == double.INFINITY) {

+ if (value.primitiveValue == double.INFINITY) {

precedence = MULTIPLICATIVE;

tok = new StringToken.fromString(STRING_INFO, '1/0.0', -1);

- } else if (value.value == double.NEGATIVE_INFINITY) {

+ } else if (value.primitiveValue == double.NEGATIVE_INFINITY) {

precedence = MULTIPLICATIVE;

tok = new StringToken.fromString(STRING_INFO, '-1/0.0', -1);

- } else if (value.value.isNaN) {

+ } else if (value.primitiveValue.isNaN) {

precedence = MULTIPLICATIVE;

tok = new StringToken.fromString(STRING_INFO, '0/0.0', -1);

}