Have PlatformEventObserver implementations orderly stop on destruction.

Have PlatformEventObserver implementations orderly stop on destruction.

Move out the stop-a-still-observing-observer-on-destruct handling to the
destructors of the objects that implement the pure virtual
SendStopMessage().

Cannot call upon a virtual from within ~PlatformEventObserver.

R=jochen@chromium.org,mkwst@chromium.org,mlamouri@chromium.org
BUG=

Committed: https://crrev.com/89f23cffd859b3dc00c98686209e2ab5343ede80
Cr-Commit-Position: refs/heads/master@{#297614}

[sof, 2014-09-30 11:44:04]

sigbjornf@opera.com changed reviewers:
+ jochen@chromium.org, mlamouri@chromium.org

[sof, 2014-09-30 11:44:05]

Please take a look.

Ran into while working on https://codereview.chromium.org/618673002/

[Mike West, 2014-09-30 11:54:14]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-09-30 11:54:15]

Drive-by LGTM. You'll need an OWNER for the code, obviously, but this really
increases clarity.

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
File content/public/renderer/platform_event_observer.h (right):

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
content/public/renderer/platform_event_observer.h:69: DCHECK(!is_observing());
This is a good change.

[Mike West, 2014-09-30 11:55:32]

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
File content/public/renderer/platform_event_observer.h (right):

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
content/public/renderer/platform_event_observer.h:111: // from their destructor
to shutdown in an orderly manner .
Nit: Kill the space before the '.'.

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
content/public/renderer/platform_event_observer.h:112: // (As Stop() calls a
virtual method, it cannot be done handled by
Nit: s/done //

[sof, 2014-09-30 12:03:41]

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
File content/public/renderer/platform_event_observer.h (right):

https://codereview.chromium.org/613203002/diff/1/content/public/renderer/plat...
content/public/renderer/platform_event_observer.h:112: // (As Stop() calls a
virtual method, it cannot be done handled by
On 2014/09/30 11:55:32, Mike West wrote:
> Nit: s/done //

Thanks for catching that, tidied. My comment proof reading could be be better.

[mlamouri (slow - plz ping), 2014-09-30 17:02:32]

lgtm. Though even if I wrote the code, I do not think I own it.

[mlamouri (slow - plz ping), 2014-09-30 17:03:17]

mlamouri@chromium.org changed reviewers:
+ avi@chromium.org

[mlamouri (slow - plz ping), 2014-09-30 17:03:18]

+avi@ for content/ OWNER.

[jochen (gone - plz use gerrit), 2014-10-01 07:34:53]

lgtm

[sof, 2014-10-01 08:16:59]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-10-01 08:17:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/613203002/20001

[commit-bot: I haz the power, 2014-10-01 09:12:18]

Committed patchset #2 (id:20001) as 9e2ab81bf0bedeb67a286b1ca244b97c7c8a6cc7

[commit-bot: I haz the power, 2014-10-01 09:12:59]

Patchset 2 (id:??) landed as
https://crrev.com/89f23cffd859b3dc00c98686209e2ab5343ede80
Cr-Commit-Position: refs/heads/master@{#297614}