content/renderer/screen_orientation/screen_orientation_observer.h - Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_observer.h

Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up a comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/gamepad_shared_memory_reader.cc ('k') | content/renderer/screen_orientation/screen_orientation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_observer.h

diff --git a/content/renderer/screen_orientation/screen_orientation_observer.h b/content/renderer/screen_orientation/screen_orientation_observer.h

index f1ed843f819f16db5e3673755a92c21e9ed29178..1c6b5bf932acee7f3857d51b9b7bc4e37b369859 100644

--- a/content/renderer/screen_orientation/screen_orientation_observer.h

+++ b/content/renderer/screen_orientation/screen_orientation_observer.h

@@ -19,6 +19,7 @@ class ScreenOrientationObserver

: public PlatformEventObserver<blink::WebPlatformEventListener> {

public:

ScreenOrientationObserver();

+ virtual ~ScreenOrientationObserver();

// Overriding this method just to make sure |listener| is always null.

virtual void Start(blink::WebPlatformEventListener* listener) OVERRIDE;