content/shell/renderer/test_runner/gamepad_controller.cc - Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/gamepad_controller.cc

Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up a comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/test_runner/gamepad_controller.cc

diff --git a/content/shell/renderer/test_runner/gamepad_controller.cc b/content/shell/renderer/test_runner/gamepad_controller.cc

index e9704d51961aa6a5fd47452b944d5b925dcd2029..4637ab0fc1d2fc6c7c90fd6b4414492cd1e145bd 100644

--- a/content/shell/renderer/test_runner/gamepad_controller.cc

+++ b/content/shell/renderer/test_runner/gamepad_controller.cc

@@ -151,7 +151,9 @@ GamepadController::GamepadController()

Reset();

}

-GamepadController::~GamepadController() {}

+GamepadController::~GamepadController() {

+ StopIfObserving();

void GamepadController::Reset() {

memset(&gamepads_, 0, sizeof(gamepads_));

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_observer.cc ('k') | no next file » | no next file with comments »