content/renderer/screen_orientation/screen_orientation_observer.cc - Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_observer.cc

Issue 613203002: Have PlatformEventObserver implementations orderly stop on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up a comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_observer.h ('k') | content/shell/renderer/test_runner/gamepad_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_observer.cc

diff --git a/content/renderer/screen_orientation/screen_orientation_observer.cc b/content/renderer/screen_orientation/screen_orientation_observer.cc

index e3fc407ed1331b8b5ef3d2017c0530b727f5673d..8cb05fe386946bf7b154cd951bc6bd7a35d12d6c 100644

--- a/content/renderer/screen_orientation/screen_orientation_observer.cc

+++ b/content/renderer/screen_orientation/screen_orientation_observer.cc

@@ -11,6 +11,10 @@ namespace content {

ScreenOrientationObserver::ScreenOrientationObserver() {

}

+ScreenOrientationObserver::~ScreenOrientationObserver() {

+ StopIfObserving();

void ScreenOrientationObserver::Start(

blink::WebPlatformEventListener* listener) {

// This should never be called with a proper listener.