Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 60093005: Introduce addps/subps/mulps/divps for IA32/X64 (Closed)

Created:
7 years, 1 month ago by Weiliang
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Introduce addps/subps/mulps/divps for IA32/X64 BUG= R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17842

Patch Set 1 #

Patch Set 2 : Put all SSE1 instruction after SSE2 flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -85 lines) Patch
M src/ia32/assembler-ia32.h View 4 chunks +24 lines, -8 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 8 chunks +53 lines, -35 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +31 lines, -20 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 5 chunks +111 lines, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +24 lines, -13 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 3 chunks +28 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Weiliang
7 years, 1 month ago (2013-11-14 05:26:43 UTC) #1
Sven Panne
LGTM, I'll land it for you
7 years, 1 month ago (2013-11-18 14:47:48 UTC) #2
Sven Panne
7 years, 1 month ago (2013-11-18 15:24:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17842.

Powered by Google App Engine
This is Rietveld 408576698