Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed)

Created:
6 years, 3 months ago by Sungmann Cho
Modified:
6 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, wjia+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace some hard coded schemes with the constants in /url/url_constants.h. Committed: https://crrev.com/8a8db05c0b62f1d7e804b48caf53ba14cbd007e5 Cr-Commit-Position: refs/heads/master@{#296328}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/site_isolation_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_info_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/url_request_info_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/savable_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 3 months ago (2014-09-23 08:09:41 UTC) #2
Charlie Reis
LGTM with nit. https://codereview.chromium.org/598453004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/598453004/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc#newcode1161 content/shell/renderer/test_runner/web_test_proxy.cc:1161: if (!host.empty() && (url.SchemeIs(url::kHttpScheme) || url.SchemeIs(url::kHttpsScheme))) ...
6 years, 3 months ago (2014-09-23 23:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598453004/20001
6 years, 3 months ago (2014-09-24 00:30:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/17843) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/12537)
6 years, 3 months ago (2014-09-24 00:36:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598453004/20001
6 years, 3 months ago (2014-09-24 01:21:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0ccd4e0f66189bb9a213fa2ba7d4dc47d3e614ea
6 years, 3 months ago (2014-09-24 01:59:36 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 02:00:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a8db05c0b62f1d7e804b48caf53ba14cbd007e5
Cr-Commit-Position: refs/heads/master@{#296328}

Powered by Google App Engine
This is Rietveld 408576698